[PATCH] [llvm] [Hexagon] Adding tests, TableGen entries, and code for emitting add opcode.

Rafael Avila de Espindola rafael.espindola at gmail.com
Fri Oct 10 21:03:50 PDT 2014

Sent from my iPhone

> On Oct 10, 2014, at 19:01, "colinl at codeaurora.org" <colinl at codeaurora.org> wrote:
> I think I understand the reason for the request now.  It sounds like you're saying the translation between assembly and machine code is most efficiently and compactly represented by assembling or disassembling and since we have a tool for that, it would be nice to use it.  That logic makes sense.
> I factored the unit test and it seems like they can be represented in a compact form which might satisfy the terseness request.
> If this change is still rejected Sid is investigating disassembler patches though it make take a few to get all the required parts in place.

Please do try to use the disassembler. It is silly to have to write c++ code to check the encoding of an instruction, specially when all other architectures use llvm-mc.

> http://reviews.llvm.org/D5624
> Files:
>  lib/Target/Hexagon/HexagonAsmPrinter.cpp
>  lib/Target/Hexagon/HexagonInstrInfo.td
>  lib/Target/Hexagon/HexagonMCInstLower.cpp
>  lib/Target/Hexagon/InstPrinter/HexagonInstPrinter.cpp
>  lib/Target/Hexagon/MCTargetDesc/HexagonMCCodeEmitter.cpp
>  lib/Target/Hexagon/MCTargetDesc/HexagonMCInst.cpp
>  lib/Target/Hexagon/MCTargetDesc/HexagonMCInst.h
>  lib/Target/Hexagon/MCTargetDesc/HexagonMCTargetDesc.cpp
>  lib/Target/Hexagon/MCTargetDesc/HexagonMCTargetDesc.h
>  unittests/MC/CMakeLists.txt
>  unittests/MC/Hexagon/HexagonMCCodeEmitterTest.cpp
> <D5624.14754.patch>

More information about the llvm-commits mailing list