[PATCH] [RFC] Use llvm-symbolizer to symbolize LLVM/Clang crash dumps

Alexey Samsonov vonosmas at gmail.com
Fri Oct 10 15:00:25 PDT 2014

Comment at: lib/Support/Unix/Signals.inc:275
@@ -266,1 +274,3 @@
+#if HAVE_LINK_H && defined(__linux__)
+struct DlIteratePhdrData {
emaste wrote:
> This builds on FreeBSD (with the __linux__ removed again) after your `ElfW(Phdr)`->`auto *phdr` change
I've included FreeBSD and NetBSD here.

Comment at: lib/Support/Unix/Signals.inc:287
@@ +286,3 @@
+  DlIteratePhdrData *data = (DlIteratePhdrData*)arg;
+  const char *name = data->first ? data->main_exec_name : info->dlpi_name;
+  data->first = false;
emaste wrote:
> This conditional is not be needed on FreeBSD, since on FreeBSD dl_iterate_phdr returns the executable with full path name in dlpi_name.
I'd prefer to leave this condition as is, and don't special-case on it. We already have main executable at this point, why not use it?


More information about the llvm-commits mailing list