[PATCH] [llvm] [Hexagon] Adding tests, TableGen entries, and code for emitting add opcode.

colinl at codeaurora.org colinl at codeaurora.org
Fri Oct 10 09:39:18 PDT 2014

>>! In D5624#16, @rafael wrote:
>> Test quality is a good point.  What we've been doing internally to keep the test quality high is using them as our source-of-truth for correct encoding.  We thought unit-tests would be more of a library-centric approach rather than a toolchain-centric with files or calls out to other tools in the system.
>> Do you think we can push up a few more of these unit tests in the next week or so and see how it shapes up or is this more of a blocking issue?  I think in the end you'll be happy with the quality.
> I really don't want to have gtests for encoding in the long run. I
> could see using them as a *short* term compromise, but It looks like
> disassembler tests should do the job, why not use them?
> Cheers,
> Rafael

With uploading .o files and disassembling them as a test we thought it would be difficult to document a process on how the public can regenerate the .o files if needed or add more in the future if we encounter a bug.  We had thought adding unit tests would be more in line with the goals of being a library rather than a file-mover as with our implementation in a different toolchain.

One thing we could do to address the concern about a huge cpp file would be to break the files up in to logical units based on the instruction category in the documentation.  We would have to make some changes internally but if that helps with organization we could make that change.  Would you want us to do that when submitting follow up patches with tests?


More information about the llvm-commits mailing list