[PATCH] Add minnum / maxnum to APFloat

Chandler Carruth chandlerc at gmail.com
Thu Oct 9 21:30:24 PDT 2014

Feel free to submit once suggestions are addressed.

Comment at: include/llvm/ADT/APFloat.h:621-625
@@ -620,1 +620,7 @@
+APFloat minnum(const APFloat &, const APFloat &);
+APFloat maxnum(const APFloat &, const APFloat &);
 } // namespace llvm
Please provide nice documenting comments for the semantics. Especially important to call out that these model IEEE's functionality and are not std::max.

Finally, why not inline? These seem reasonable inlining candidates....


More information about the llvm-commits mailing list