[llvm] r219469 - [LVI] Revert the remainder of "r218231 - Add two thresholds lvi-overdefined-BB-threshold and lvi-overdefined-threshold"

Hal Finkel hfinkel at anl.gov
Thu Oct 9 20:56:24 PDT 2014


Author: hfinkel
Date: Thu Oct  9 22:56:24 2014
New Revision: 219469

URL: http://llvm.org/viewvc/llvm-project?rev=219469&view=rev
Log:
[LVI] Revert the remainder of "r218231 - Add two thresholds lvi-overdefined-BB-threshold and lvi-overdefined-threshold"

Some of r218231 was reverted with the code that used it in r218971, but not all
of it. This removes the rest (which is now dead).

Modified:
    llvm/trunk/lib/Analysis/LazyValueInfo.cpp

Modified: llvm/trunk/lib/Analysis/LazyValueInfo.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/LazyValueInfo.cpp?rev=219469&r1=219468&r2=219469&view=diff
==============================================================================
--- llvm/trunk/lib/Analysis/LazyValueInfo.cpp (original)
+++ llvm/trunk/lib/Analysis/LazyValueInfo.cpp Thu Oct  9 22:56:24 2014
@@ -27,7 +27,6 @@
 #include "llvm/IR/IntrinsicInst.h"
 #include "llvm/IR/PatternMatch.h"
 #include "llvm/IR/ValueHandle.h"
-#include "llvm/Support/CommandLine.h"
 #include "llvm/Support/Debug.h"
 #include "llvm/Support/raw_ostream.h"
 #include "llvm/Target/TargetLibraryInfo.h"
@@ -38,20 +37,6 @@ using namespace PatternMatch;
 
 #define DEBUG_TYPE "lazy-value-info"
 
-// Experimentally derived threshold for the number of basic blocks lowered for
-// lattice value overdefined.
-static cl::opt<unsigned>
-OverdefinedBBThreshold("lvi-overdefined-BB-threshold",
-    cl::init(1500), cl::Hidden,
-    cl::desc("Threshold of the number of basic blocks lowered for lattice value"
-             "'overdefined'."));
-
-// Experimentally derived threshold for additional lowering lattice values
-// overdefined per block.
-static cl::opt<unsigned>
-OverdefinedThreshold("lvi-overdefined-threshold", cl::init(10), cl::Hidden,
-    cl::desc("Threshold of lowering lattice value 'overdefined'."));
-
 char LazyValueInfo::ID = 0;
 INITIALIZE_PASS_BEGIN(LazyValueInfo, "lazy-value-info",
                 "Lazy Value Information Analysis", false, true)
@@ -363,9 +348,6 @@ namespace {
     const DataLayout *DL;
     /// An optional DT pointer.
     DominatorTree *DT;
-    /// A counter to record how many times Overdefined has been tried to be
-    /// lowered.
-    DenseMap<BasicBlock *, unsigned> LoweringOverdefinedTimes;
     
     friend struct LVIValueHandle;
     
@@ -498,9 +480,6 @@ void LazyValueInfoCache::eraseBlock(Basi
 }
 
 void LazyValueInfoCache::solve() {
-  // Reset the counter of lowering overdefined value.
-  LoweringOverdefinedTimes.clear();
-
   while (!BlockValueStack.empty()) {
     std::pair<BasicBlock*, Value*> &e = BlockValueStack.top();
     if (solveBlockValue(e.second, e.first)) {
@@ -559,7 +538,6 @@ bool LazyValueInfoCache::solveBlockValue
   // lattice value to overdefined, so that cycles will terminate and be
   // conservatively correct.
   BBLV.markOverdefined();
-  ++LoweringOverdefinedTimes[BB];
   
   Instruction *BBI = dyn_cast<Instruction>(Val);
   if (!BBI || BBI->getParent() != BB) {





More information about the llvm-commits mailing list