[PATCH] [Polly][Refactor][NFC] Simplify and clean the handling of (new) access relations
doerfert at cs.uni-saarland.de
Thu Oct 9 13:19:48 PDT 2014
Comment at: include/polly/ScopInfo.h:245
@@ +244,3 @@
+ /// @brief Get the new access function imported or set by a pass
+ isl_map *getNewAccessRelation() const;
> Does these two methods need to be public? If not it would be good to make them private to avoid confusion over which method to call (e.g. `getAccessRelation`, `getNewAccessRelation`, `getNewestAccessRelation`). I'm not too familiar with the API, so do whatever makes sense.
> Otherwise, LGTM.
I will expose getNewestAccessRelation and replace all uses (only in 2 files outside the ScopInfo itself, at the moment).
I cannot see any reason not to use the newest access function except in the dependence analysi but the importer runs after that pass and nobody else (at least for now) uses the functionality of a new access relation anyway.
More information about the llvm-commits