[PATCH] Add ErrorOr<>::getOrDie() which uses report_fatal_error instead of assert.

Reid Kleckner rnk at google.com
Thu Oct 9 11:29:16 PDT 2014


I don't think we should be burying invisible calls to report_fatal_error in
libraries. Can you point at the code which wants to do this?

On Thu, Oct 9, 2014 at 10:30 AM, Alexander Kornienko <alexfh at google.com>
wrote:

> Hi rafael,
>
> This method allows writing code that consistently fails in case of
> dereferencing an ErrorOr<> containing no value rather than crashing in
> debug and
> using uninitialized data in release build.
>
> http://reviews.llvm.org/D5706
>
> Files:
>   include/llvm/Support/ErrorOr.h
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141009/c2c90601/attachment.html>


More information about the llvm-commits mailing list