[PATCH] Object: Add range iterators for COFF import/export table

David Majnemer david.majnemer at gmail.com
Wed Oct 8 18:57:34 PDT 2014


LGTM

================
Comment at: tools/llvm-readobj/COFFDumper.cpp:78
@@ -77,5 +77,3 @@
                                     uint64_t Offset, StringRef &Name);
-
-  void printImportedSymbols(imported_symbol_iterator I,
-                            imported_symbol_iterator E);
+  void printImportedSymbols(iterator_range<imported_symbol_iterator> range);
 
----------------
Please capitalize `range` to `Range`.

================
Comment at: tools/llvm-readobj/COFFDumper.cpp:888
@@ +887,3 @@
+void COFFDumper::printImportedSymbols(
+    iterator_range<imported_symbol_iterator> range) {
+  for (const ImportedSymbolRef &I : range) {
----------------
Likewise.

http://reviews.llvm.org/D5685






More information about the llvm-commits mailing list