[PATCH] [dwarfdump] Prettyprint DW_AT_APPLE_property_attribute bitfield values.

Frederic Riss friss at apple.com
Wed Oct 8 17:23:01 PDT 2014

>>! In D5689#4, @dblaikie wrote:
> Looks reasonable (apart from testing) - depends how you want to do it. I assume there are some existing tests that test properties that could be updated to use this feature? (does this not regress any existing tests?)
> If there aren't any such tests, I imagine we want some - and they could just test this incidentally.
> (I'm usually on the fence about writing tool tests separately from unit tests... *shrug* sometimes it's nice, sometimes it seems like overkill)

There aren't any. I discovered the discrepancy between the enum values yesterday by trying to produce some tests and the results didn't actually make sense. I can add an llvm test, sure, but my ObjC foo being what it is, I fear that the code won't make any sense :-) Thus it won't test much except the actual dumping.


More information about the llvm-commits mailing list