[lld] r219341 - Use llvm::StringSwitch.

Rui Ueyama ruiu at google.com
Wed Oct 8 14:08:15 PDT 2014


Author: ruiu
Date: Wed Oct  8 16:08:15 2014
New Revision: 219341

URL: http://llvm.org/viewvc/llvm-project?rev=219341&view=rev
Log:
Use llvm::StringSwitch.

Modified:
    lld/trunk/lib/ReaderWriter/PECOFF/WriterPECOFF.cpp

Modified: lld/trunk/lib/ReaderWriter/PECOFF/WriterPECOFF.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/PECOFF/WriterPECOFF.cpp?rev=219341&r1=219340&r2=219341&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/PECOFF/WriterPECOFF.cpp (original)
+++ lld/trunk/lib/ReaderWriter/PECOFF/WriterPECOFF.cpp Wed Oct  8 16:08:15 2014
@@ -1030,26 +1030,23 @@ void PECOFFWriter::build(const File &lin
         peHeader->setAddressOfEntryPoint(0);
       }
     }
-    if (section->getSectionName() == ".data")
+    StringRef name = section->getSectionName();
+    if (name == ".data") {
       peHeader->setBaseOfData(section->getVirtualAddress());
-    if (section->getSectionName() == ".pdata")
-      dataDirectory->setField(DataDirectoryIndex::EXCEPTION_TABLE,
-                              section->getVirtualAddress(), section->size());
-    if (section->getSectionName() == ".rsrc")
-      dataDirectory->setField(DataDirectoryIndex::RESOURCE_TABLE,
-                              section->getVirtualAddress(), section->size());
-    if (section->getSectionName() == ".idata.a")
-      dataDirectory->setField(DataDirectoryIndex::IAT,
-                              section->getVirtualAddress(), section->size());
-    if (section->getSectionName() == ".idata.d")
-      dataDirectory->setField(DataDirectoryIndex::IMPORT_TABLE,
-                              section->getVirtualAddress(), section->size());
-    if (section->getSectionName() == ".edata")
-      dataDirectory->setField(DataDirectoryIndex::EXPORT_TABLE,
-                              section->getVirtualAddress(), section->size());
-    if (section->getSectionName() == ".loadcfg")
-      dataDirectory->setField(DataDirectoryIndex::LOAD_CONFIG_TABLE,
-                              section->getVirtualAddress(), section->size());
+      continue;
+    }
+    DataDirectoryIndex ignore = DataDirectoryIndex(-1);
+    DataDirectoryIndex idx = llvm::StringSwitch<DataDirectoryIndex>(name)
+        .Case(".pdata", DataDirectoryIndex::EXCEPTION_TABLE)
+        .Case(".rsrc", DataDirectoryIndex::RESOURCE_TABLE)
+        .Case(".idata.a", DataDirectoryIndex::IAT)
+        .Case(".idata.d", DataDirectoryIndex::IMPORT_TABLE)
+        .Case(".edata", DataDirectoryIndex::EXPORT_TABLE)
+        .Case(".loadcfg", DataDirectoryIndex::LOAD_CONFIG_TABLE)
+        .Default(ignore);
+    if (idx == ignore)
+      continue;
+    dataDirectory->setField(idx, section->getVirtualAddress(), section->size());
   }
 
   if (const DefinedAtom *atom = findTLSUsedSymbol(_ctx, linkedFile)) {





More information about the llvm-commits mailing list