[PATCH] [PATCH] Test case and FastISel fixes with FeatureVSX enabled

[Eric Christopher]

Not such a huge fan of the new EVT code. This is what the Type *, MVT
& code is for. What's giving you an EVT where you're not checking for
simple?

I.e. I see no reason this shouldn't work like:

bool PPCFastISel::isTypeLegal(Type *Ty, MVT &VT) {
  EVT E = TLI.getValueType(Ty, true);

  // Only handle simple types.
  if (E == MVT::Other || !E.isSimple())
    return false;
  VT = E.getSimpleVT();

  if (VT == MVT::f64 || VT.isVector())
    return false;

  return TLI.isTypeLegal(VT);
}

(though do we handle f64 or vectors if we don't have VSX? Do we need
both checks? etc)

-eric

On Wed, Oct 8, 2014 at 1:46 PM, Bill Seurer <seurer at linux.vnet.ibm.com> wrote:
> Changes to fma.ll to fix merging
>
> http://reviews.llvm.org/D5362
>
> Files:
>   /home/seurer/llvm/llvm-test/include/llvm/CodeGen/FastISel.h
>   /home/seurer/llvm/llvm-test/lib/CodeGen/SelectionDAG/FastISel.cpp
>   /home/seurer/llvm/llvm-test/lib/Target/PowerPC/PPCFastISel.cpp
>   /home/seurer/llvm/llvm-test/test/CodeGen/Generic/select-cc.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/2007-09-08-unaligned.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/2012-10-12-bitcast.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/buildvec_canonicalize.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/copysignl.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/fabs.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/fast-isel-call.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/fast-isel-cmp-imm.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/fast-isel-conversion.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/fast-isel-load-store.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/fast-isel-ret.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/fcpsgn.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/fma.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/fnabs.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/fp-branch.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/fp_to_uint.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/fsel.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/fsqrt.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/i64_fp.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/mcm-12.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/mcm-4.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/ppc64-align-long-double.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/recipest.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/rounding-ops.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/select-cc.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/unaligned.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/unsafe-math.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/vec_mul.ll