[PATCH] [PATCH] Test case and FastISel fixes with FeatureVSX enabled

Eric Christopher echristo at gmail.com
Wed Oct 8 13:34:48 PDT 2014


Out of curiosity, why not this patch?

dzur:~/sources/llvm> git diff
diff --git a/lib/Target/PowerPC/PPCFastISel.cpp
b/lib/Target/PowerPC/PPCFastISel.cpp
index 99aa4ea..b36c5c8 100644
--- a/lib/Target/PowerPC/PPCFastISel.cpp
+++ b/lib/Target/PowerPC/PPCFastISel.cpp
@@ -2284,7 +2284,7 @@ namespace llvm {

     // Only available on 64-bit ELF for now.
     const PPCSubtarget *Subtarget = &TM.getSubtarget<PPCSubtarget>();
-    if (Subtarget->isPPC64() && Subtarget->isSVR4ABI())
+    if (Subtarget->isPPC64() && Subtarget->isSVR4ABI() && !Subtarget->hasVSX())
       return new PPCFastISel(FuncInfo, LibInfo);

     return nullptr;

On Wed, Oct 8, 2014 at 1:16 PM, Bill Seurer <seurer at linux.vnet.ibm.com> wrote:
> Removed default FeatureVSX in PPC.td
> Two changes in FastISel.cpp to avoid svn code merge problems
>
> After discussing this with Bill Schmidt we decided to not turn on FeatureVSX by default.  There are some recent code updates elsewhere (unrelated to this) which cause register issues when FeatureVSX is turned on.
>
> http://reviews.llvm.org/D5362
>
> Files:
>   /home/seurer/llvm/llvm-test/include/llvm/CodeGen/FastISel.h
>   /home/seurer/llvm/llvm-test/lib/CodeGen/SelectionDAG/FastISel.cpp
>   /home/seurer/llvm/llvm-test/lib/Target/PowerPC/PPCFastISel.cpp
>   /home/seurer/llvm/llvm-test/test/CodeGen/Generic/select-cc.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/2007-09-08-unaligned.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/2012-10-12-bitcast.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/buildvec_canonicalize.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/copysignl.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/fabs.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/fast-isel-call.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/fast-isel-cmp-imm.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/fast-isel-conversion.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/fast-isel-load-store.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/fast-isel-ret.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/fcpsgn.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/fma.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/fnabs.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/fp-branch.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/fp_to_uint.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/fsel.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/fsqrt.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/i64_fp.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/mcm-12.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/mcm-4.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/ppc64-align-long-double.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/recipest.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/rounding-ops.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/select-cc.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/unaligned.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/unsafe-math.ll
>   /home/seurer/llvm/llvm-test/test/CodeGen/PowerPC/vec_mul.ll



More information about the llvm-commits mailing list