[compiler-rt] r219293 - Custom wrappers for DFSanitizing sprintf & snprintf.

Lorenzo Martignoni martignlo at google.com
Wed Oct 8 03:01:43 PDT 2014


Author: martignlo
Date: Wed Oct  8 05:01:42 2014
New Revision: 219293

URL: http://llvm.org/viewvc/llvm-project?rev=219293&view=rev
Log:
Custom wrappers for DFSanitizing sprintf & snprintf.

Differential Revision: http://reviews.llvm.org/D5561


Added:
    compiler-rt/trunk/test/dfsan/custom.cc
      - copied, changed from r219288, compiler-rt/trunk/test/dfsan/custom.c
Removed:
    compiler-rt/trunk/test/dfsan/custom.c
Modified:
    compiler-rt/trunk/lib/dfsan/dfsan_custom.cc
    compiler-rt/trunk/lib/dfsan/done_abilist.txt
    compiler-rt/trunk/lib/dfsan/scripts/check_custom_wrappers.sh
    compiler-rt/trunk/lib/sanitizer_common/scripts/check_lint.sh
    compiler-rt/trunk/test/sanitizer_common/lit.common.cfg

Modified: compiler-rt/trunk/lib/dfsan/dfsan_custom.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/dfsan/dfsan_custom.cc?rev=219293&r1=219292&r2=219293&view=diff
==============================================================================
--- compiler-rt/trunk/lib/dfsan/dfsan_custom.cc (original)
+++ compiler-rt/trunk/lib/dfsan/dfsan_custom.cc Wed Oct  8 05:01:42 2014
@@ -12,12 +12,14 @@
 // This file defines the custom functions listed in done_abilist.txt.
 //===----------------------------------------------------------------------===//
 
+#include "sanitizer_common/sanitizer_common.h"
 #include "sanitizer_common/sanitizer_internal_defs.h"
 #include "sanitizer_common/sanitizer_linux.h"
 
 #include "dfsan/dfsan.h"
 
 #include <arpa/inet.h>
+#include <assert.h>
 #include <ctype.h>
 #include <dlfcn.h>
 #include <link.h>
@@ -26,6 +28,8 @@
 #include <pwd.h>
 #include <sched.h>
 #include <signal.h>
+#include <stdarg.h>
+#include <stdint.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
@@ -839,4 +843,281 @@ __dfsw_write(int fd, const void *buf, si
   *ret_label = 0;
   return write(fd, buf, count);
 }
+
+// Type used to extract a dfsan_label with va_arg()
+typedef int dfsan_label_va;
+
+// A chunk of data representing the output of formatting either a constant
+// string or a single format directive.
+struct Chunk {
+  // Address of the beginning of the formatted string
+  const char *ptr;
+  // Size of the formatted string
+  size_t size;
+
+  // Type of DFSan label (depends on the format directive)
+  enum {
+    // Constant string, no argument and thus no label
+    NONE = 0,
+    // Label for an argument of '%n'
+    IGNORED,
+    // Label for a '%s' argument
+    STRING,
+    // Label for any other type of argument
+    NUMERIC,
+  } label_type;
+
+  // Value of the argument (if label_type == STRING)
+  const char *arg;
+};
+
+// Formats the input. The output is stored in 'str' starting from offset
+// 'off'. The format directive is represented by the first 'format_size' bytes
+// of 'format'. If 'has_size' is true, 'size' bounds the number of output
+// bytes. Returns the return value of the vsnprintf call used to format the
+// input.
+static int format_chunk(char *str, size_t off, bool has_size, size_t size,
+                        const char *format, size_t format_size, ...) {
+  char *chunk_format = (char *) malloc(format_size + 1);
+  assert(chunk_format);
+  internal_memcpy(chunk_format, format, format_size);
+  chunk_format[format_size] = '\0';
+
+  va_list ap;
+  va_start(ap, format_size);
+  int r = 0;
+  if (has_size) {
+    r = vsnprintf(str + off, off < size ? size - off : 0, chunk_format, ap);
+  } else {
+    r = vsprintf(str + off, chunk_format, ap);
+  }
+  va_end(ap);
+
+  free(chunk_format);
+  return r;
+}
+
+// Formats the input and propagates the input labels to the output. The output
+// is stored in 'str'. If 'has_size' is true, 'size' bounds the number of
+// output bytes. 'format' and 'ap' are the format string and the list of
+// arguments for formatting. Returns the return value vsnprintf would return.
+//
+// The function tokenizes the format string in chunks representing either a
+// constant string or a single format directive (e.g., '%.3f') and formats each
+// chunk independently into the output string. This approach allows to figure
+// out which bytes of the output string depends on which argument and thus to
+// propagate labels more precisely.
+static int format_buffer(char *str, bool has_size, size_t size,
+                         const char *format, va_list ap) {
+  InternalMmapVector<Chunk> chunks(8);
+  size_t off = 0;
+
+  while (*format) {
+    chunks.push_back(Chunk());
+    Chunk& chunk = chunks.back();
+    chunk.ptr = str + off;
+    chunk.arg = nullptr;
+
+    int status = 0;
+
+    if (*format != '%') {
+      // Ordinary character. Consume all the characters until a '%' or the end
+      // of the string.
+      size_t format_size = 0;
+      for (; *format && *format != '%'; ++format, ++format_size) {}
+      status = format_chunk(str, off, has_size, size, format - format_size,
+                            format_size);
+      chunk.label_type = Chunk::NONE;
+    } else {
+      // Conversion directive. Consume all the characters until a conversion
+      // specifier or the end of the string.
+      bool end_format = false;
+#define FORMAT_CHUNK(t)                                                  \
+      format_chunk(str, off, has_size, size, format - format_size,  \
+                   format_size + 1, va_arg(ap, t))
+
+      for (size_t format_size = 1; *++format && !end_format; ++format_size) {
+        switch (*format) {
+          case 'd':
+          case 'i':
+          case 'o':
+          case 'u':
+          case 'x':
+          case 'X':
+            switch (*(format - 1)) {
+              case 'h':
+                // Also covers the 'hh' case (since the size of the arg is still
+                // an int).
+                status = FORMAT_CHUNK(int);
+                break;
+              case 'l':
+                if (format_size >= 2 && *(format - 2) == 'l') {
+                  status = FORMAT_CHUNK(long long int);
+                } else {
+                  status = FORMAT_CHUNK(long int);
+                }
+                break;
+              case 'q':
+                status = FORMAT_CHUNK(long long int);
+                break;
+              case 'j':
+                status = FORMAT_CHUNK(intmax_t);
+                break;
+              case 'z':
+                status = FORMAT_CHUNK(size_t);
+                break;
+              case 't':
+                status = FORMAT_CHUNK(size_t);
+                break;
+              default:
+                status = FORMAT_CHUNK(int);
+            }
+            chunk.label_type = Chunk::NUMERIC;
+            end_format = true;
+            break;
+
+          case 'a':
+          case 'A':
+          case 'e':
+          case 'E':
+          case 'f':
+          case 'F':
+          case 'g':
+          case 'G':
+            if (*(format - 1) == 'L') {
+              status = FORMAT_CHUNK(long double);
+            } else {
+              status = FORMAT_CHUNK(double);
+            }
+            chunk.label_type = Chunk::NUMERIC;
+            end_format = true;
+            break;
+
+          case 'c':
+            status = FORMAT_CHUNK(int);
+            chunk.label_type = Chunk::NUMERIC;
+            end_format = true;
+            break;
+
+          case 's':
+            chunk.arg = va_arg(ap, char *);
+            status =
+                format_chunk(str, off, has_size, size,
+                             format - format_size, format_size + 1,
+                             chunk.arg);
+            chunk.label_type = Chunk::STRING;
+            end_format = true;
+            break;
+
+          case 'p':
+            status = FORMAT_CHUNK(void *);
+            chunk.label_type = Chunk::NUMERIC;
+            end_format = true;
+            break;
+
+          case 'n':
+            *(va_arg(ap, int *)) = (int)off;
+            chunk.label_type = Chunk::IGNORED;
+            end_format = true;
+            break;
+
+          case '%':
+            status = format_chunk(str, off, has_size, size,
+                                  format - format_size, format_size + 1);
+            chunk.label_type = Chunk::NONE;
+            end_format = true;
+            break;
+
+          default:
+            break;
+        }
+      }
+#undef FORMAT_CHUNK
+    }
+
+    if (status < 0) {
+      return status;
+    }
+
+    // A return value of {v,}snprintf of size or more means that the output was
+    // truncated.
+    if (has_size) {
+      if (off < size) {
+        size_t ustatus = (size_t) status;
+        chunk.size = ustatus >= (size - off) ?
+            ustatus - (size - off) : ustatus;
+      } else {
+        chunk.size = 0;
+      }
+    } else {
+      chunk.size = status;
+    }
+    off += status;
+  }
+
+  // Consume the labels of the output buffer, (optional) size, and format
+  // string.
+  //
+  // TODO(martignlo): Decide how to combine labels (e.g., whether to ignore or
+  // not the label of the format string).
+  va_arg(ap, dfsan_label_va);
+  if (has_size) {
+    va_arg(ap, dfsan_label_va);
+  }
+  va_arg(ap, dfsan_label_va);
+
+  // Label each output chunk according to the label supplied as argument to the
+  // function. We need to go through all the chunks and arguments even if the
+  // string was only partially printed ({v,}snprintf case).
+  for (size_t i = 0; i < chunks.size(); ++i) {
+    const Chunk& chunk = chunks[i];
+
+    switch (chunk.label_type) {
+      case Chunk::NONE:
+        dfsan_set_label(0, (void*) chunk.ptr, chunk.size);
+        break;
+      case Chunk::IGNORED:
+        va_arg(ap, dfsan_label_va);
+        dfsan_set_label(0, (void*) chunk.ptr, chunk.size);
+        break;
+      case Chunk::NUMERIC: {
+        dfsan_label label = va_arg(ap, dfsan_label_va);
+        dfsan_set_label(label, (void*) chunk.ptr, chunk.size);
+        break;
+      }
+      case Chunk::STRING: {
+        // Consume the label of the pointer to the string
+        va_arg(ap, dfsan_label_va);
+        internal_memcpy(shadow_for((void *) chunk.ptr),
+                        shadow_for((void *) chunk.arg),
+                        sizeof(dfsan_label) * (strlen(chunk.arg)));
+        break;
+      }
+    }
+  }
+
+  dfsan_label *ret_label_ptr = va_arg(ap, dfsan_label *);
+  *ret_label_ptr = 0;
+
+  // Number of bytes written in total.
+  return off;
+}
+
+SANITIZER_INTERFACE_ATTRIBUTE
+int __dfsw_sprintf(char *str, const char *format, ...) {
+  va_list ap;
+  va_start(ap, format);
+  int ret = format_buffer(str, false, 0, format, ap);
+  va_end(ap);
+  return ret;
+}
+
+SANITIZER_INTERFACE_ATTRIBUTE
+int __dfsw_snprintf(char *str, size_t size, const char *format, ...) {
+  va_list ap;
+  va_start(ap, format);
+  int ret = format_buffer(str, true, size, format, ap);
+  va_end(ap);
+  return ret;
+}
 }

Modified: compiler-rt/trunk/lib/dfsan/done_abilist.txt
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/dfsan/done_abilist.txt?rev=219293&r1=219292&r2=219293&view=diff
==============================================================================
--- compiler-rt/trunk/lib/dfsan/done_abilist.txt (original)
+++ compiler-rt/trunk/lib/dfsan/done_abilist.txt Wed Oct  8 05:01:42 2014
@@ -208,9 +208,11 @@ fun:sigemptyset=custom
 fun:sigaction=custom
 fun:gettimeofday=custom
 
+# sprintf-like
+fun:sprintf=custom
+fun:snprintf=custom
+
 # TODO: custom
-fun:snprintf=discard
-fun:vsnprintf=discard
 fun:asprintf=discard
 fun:qsort=discard
 

Modified: compiler-rt/trunk/lib/dfsan/scripts/check_custom_wrappers.sh
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/dfsan/scripts/check_custom_wrappers.sh?rev=219293&r1=219292&r2=219293&view=diff
==============================================================================
--- compiler-rt/trunk/lib/dfsan/scripts/check_custom_wrappers.sh (original)
+++ compiler-rt/trunk/lib/dfsan/scripts/check_custom_wrappers.sh Wed Oct  8 05:01:42 2014
@@ -1,7 +1,7 @@
 #!/usr/bin/env bash
 
 DFSAN_DIR=$(dirname "$0")/../
-DFSAN_CUSTOM_TESTS=${DFSAN_DIR}/../../test/dfsan/custom.c
+DFSAN_CUSTOM_TESTS=${DFSAN_DIR}/../../test/dfsan/custom.cc
 DFSAN_CUSTOM_WRAPPERS=${DFSAN_DIR}/dfsan_custom.cc
 DFSAN_ABI_LIST=${DFSAN_DIR}/done_abilist.txt
 

Modified: compiler-rt/trunk/lib/sanitizer_common/scripts/check_lint.sh
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/scripts/check_lint.sh?rev=219293&r1=219292&r2=219293&view=diff
==============================================================================
--- compiler-rt/trunk/lib/sanitizer_common/scripts/check_lint.sh (original)
+++ compiler-rt/trunk/lib/sanitizer_common/scripts/check_lint.sh Wed Oct  8 05:01:42 2014
@@ -29,7 +29,7 @@ TSAN_LIT_TEST_LINT_FILTER=${TSAN_TEST_LI
 MSAN_RTL_LINT_FILTER=${COMMON_LINT_FILTER}
 LSAN_RTL_LINT_FILTER=${COMMON_LINT_FILTER}
 LSAN_LIT_TEST_LINT_FILTER=${LSAN_RTL_LINT_FILTER},-whitespace/line_length
-DFSAN_RTL_LINT_FILTER=${COMMON_LINT_FILTER},-runtime/int,-runtime/printf,-runtime/references
+DFSAN_RTL_LINT_FILTER=${COMMON_LINT_FILTER},-runtime/int,-runtime/printf,-runtime/references,-readability/function
 COMMON_RTL_INC_LINT_FILTER=${COMMON_LINT_FILTER},-runtime/int,-runtime/sizeof,-runtime/printf,-readability/fn_size
 SANITIZER_INCLUDES_LINT_FILTER=${COMMON_LINT_FILTER},-runtime/int
 MKTEMP="mktemp -q /tmp/tmp.XXXXXXXXXX"

Removed: compiler-rt/trunk/test/dfsan/custom.c
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/dfsan/custom.c?rev=219292&view=auto
==============================================================================
--- compiler-rt/trunk/test/dfsan/custom.c (original)
+++ compiler-rt/trunk/test/dfsan/custom.c (removed)
@@ -1,833 +0,0 @@
-// RUN: %clang_dfsan -m64 %s -o %t && DFSAN_OPTIONS="strict_data_dependencies=0" %run %t
-// RUN: %clang_dfsan -mllvm -dfsan-args-abi -m64 %s -o %t && DFSAN_OPTIONS="strict_data_dependencies=0" %run %t
-// RUN: %clang_dfsan -DSTRICT_DATA_DEPENDENCIES -m64 %s -o %t && %run %t
-// RUN: %clang_dfsan -DSTRICT_DATA_DEPENDENCIES -mllvm -dfsan-args-abi -m64 %s -o %t && %run %t
-
-// Tests custom implementations of various glibc functions.
-
-#define _GNU_SOURCE
-#include <sanitizer/dfsan_interface.h>
-
-#include <arpa/inet.h>
-#include <assert.h>
-#include <fcntl.h>
-#include <link.h>
-#include <poll.h>
-#include <pthread.h>
-#include <pwd.h>
-#include <sched.h>
-#include <signal.h>
-#include <stdio.h>
-#include <stdlib.h>
-#include <string.h>
-#include <sys/select.h>
-#include <sys/resource.h>
-#include <sys/stat.h>
-#include <sys/time.h>
-#include <sys/types.h>
-#include <time.h>
-#include <unistd.h>
-
-dfsan_label i_label = 0;
-dfsan_label j_label = 0;
-dfsan_label k_label = 0;
-dfsan_label i_j_label = 0;
-
-#define ASSERT_ZERO_LABEL(data) \
-  assert(0 == dfsan_get_label((long) (data)))
-
-#define ASSERT_READ_ZERO_LABEL(ptr, size) \
-  assert(0 == dfsan_read_label(ptr, size))
-
-#define ASSERT_LABEL(data, label) \
-  assert(label == dfsan_get_label((long) (data)))
-
-#define ASSERT_READ_LABEL(ptr, size, label) \
-  assert(label == dfsan_read_label(ptr, size))
-
-void test_stat() {
-  int i = 1;
-  dfsan_set_label(i_label, &i, sizeof(i));
-
-  struct stat s;
-  s.st_dev = i;
-  assert(0 == stat("/", &s));
-  ASSERT_ZERO_LABEL(s.st_dev);
-
-  s.st_dev = i;
-  assert(-1 == stat("/nonexistent", &s));
-  ASSERT_LABEL(s.st_dev, i_label);
-}
-
-void test_fstat() {
-  int i = 1;
-  dfsan_set_label(i_label, &i, sizeof(i));
-
-  struct stat s;
-  int fd = open("/dev/zero", O_RDONLY);
-  s.st_dev = i;
-  int rv = fstat(fd, &s);
-  assert(0 == rv);
-  ASSERT_ZERO_LABEL(s.st_dev);
-}
-
-void test_memcmp() {
-  char str1[] = "str1", str2[] = "str2";
-  dfsan_set_label(i_label, &str1[3], 1);
-  dfsan_set_label(j_label, &str2[3], 1);
-
-  int rv = memcmp(str1, str2, sizeof(str1));
-  assert(rv < 0);
-#ifdef STRICT_DATA_DEPENDENCIES
-  ASSERT_ZERO_LABEL(rv);
-#else
-  ASSERT_LABEL(rv, i_j_label);
-#endif
-}
-
-void test_memcpy() {
-  char str1[] = "str1";
-  char str2[sizeof(str1)];
-  dfsan_set_label(i_label, &str1[3], 1);
-
-  ASSERT_ZERO_LABEL(memcpy(str2, str1, sizeof(str1)));
-  assert(0 == memcmp(str2, str1, sizeof(str1)));
-  ASSERT_ZERO_LABEL(str2[0]);
-  ASSERT_LABEL(str2[3], i_label);
-}
-
-void test_memset() {
-  char buf[8];
-  int j = 'a';
-  dfsan_set_label(j_label, &j, sizeof(j));
-
-  ASSERT_ZERO_LABEL(memset(&buf, j, sizeof(buf)));
-  for (int i = 0; i < 8; ++i) {
-    ASSERT_LABEL(buf[i], j_label);
-    assert(buf[i] == 'a');
-  }
-}
-
-void test_strcmp() {
-  char str1[] = "str1", str2[] = "str2";
-  dfsan_set_label(i_label, &str1[3], 1);
-  dfsan_set_label(j_label, &str2[3], 1);
-
-  int rv = strcmp(str1, str2);
-  assert(rv < 0);
-#ifdef STRICT_DATA_DEPENDENCIES
-  ASSERT_ZERO_LABEL(rv);
-#else
-  ASSERT_LABEL(rv, i_j_label);
-#endif
-}
-
-void test_strlen() {
-  char str1[] = "str1";
-  dfsan_set_label(i_label, &str1[3], 1);
-
-  int rv = strlen(str1);
-  assert(rv == 4);
-#ifdef STRICT_DATA_DEPENDENCIES
-  ASSERT_ZERO_LABEL(rv);
-#else
-  ASSERT_LABEL(rv, i_label);
-#endif
-}
-
-void test_strdup() {
-  char str1[] = "str1";
-  dfsan_set_label(i_label, &str1[3], 1);
-
-  char *strd = strdup(str1);
-  ASSERT_ZERO_LABEL(strd[0]);
-  ASSERT_LABEL(strd[3], i_label);
-  free(strd);
-}
-
-void test_strncpy() {
-  char str1[] = "str1";
-  char str2[sizeof(str1)];
-  dfsan_set_label(i_label, &str1[3], 1);
-
-  char *strd = strncpy(str2, str1, 5);
-  assert(strd == str2);
-  assert(strcmp(str1, str2) == 0);
-  ASSERT_ZERO_LABEL(strd);
-  ASSERT_ZERO_LABEL(strd[0]);
-  ASSERT_ZERO_LABEL(strd[1]);
-  ASSERT_ZERO_LABEL(strd[2]);
-  ASSERT_LABEL(strd[3], i_label);
-
-  strd = strncpy(str2, str1, 3);
-  assert(strd == str2);
-  assert(strncmp(str1, str2, 3) == 0);
-  ASSERT_ZERO_LABEL(strd);
-  ASSERT_ZERO_LABEL(strd[0]);
-  ASSERT_ZERO_LABEL(strd[1]);
-  ASSERT_ZERO_LABEL(strd[2]);
-}
-
-void test_strncmp() {
-  char str1[] = "str1", str2[] = "str2";
-  dfsan_set_label(i_label, &str1[3], 1);
-  dfsan_set_label(j_label, &str2[3], 1);
-
-  int rv = strncmp(str1, str2, sizeof(str1));
-  assert(rv < 0);
-#ifdef STRICT_DATA_DEPENDENCIES
-  ASSERT_ZERO_LABEL(rv);
-#else
-  ASSERT_LABEL(rv, dfsan_union(i_label, j_label));
-#endif
-
-  rv = strncmp(str1, str2, 3);
-  assert(rv == 0);
-  ASSERT_ZERO_LABEL(rv);
-}
-
-void test_strcasecmp() {
-  char str1[] = "str1", str2[] = "str2", str3[] = "Str1";
-  dfsan_set_label(i_label, &str1[3], 1);
-  dfsan_set_label(j_label, &str2[3], 1);
-  dfsan_set_label(j_label, &str3[2], 1);
-
-  int rv = strcasecmp(str1, str2);
-  assert(rv < 0);
-#ifdef STRICT_DATA_DEPENDENCIES
-  ASSERT_ZERO_LABEL(rv);
-#else
-  ASSERT_LABEL(rv, dfsan_union(i_label, j_label));
-#endif
-
-  rv = strcasecmp(str1, str3);
-  assert(rv == 0);
-#ifdef STRICT_DATA_DEPENDENCIES
-  ASSERT_ZERO_LABEL(rv);
-#else
-  ASSERT_LABEL(rv, dfsan_union(i_label, j_label));
-#endif
-}
-
-void test_strncasecmp() {
-  char str1[] = "Str1", str2[] = "str2";
-  dfsan_set_label(i_label, &str1[3], 1);
-  dfsan_set_label(j_label, &str2[3], 1);
-
-  int rv = strncasecmp(str1, str2, sizeof(str1));
-  assert(rv < 0);
-#ifdef STRICT_DATA_DEPENDENCIES
-  ASSERT_ZERO_LABEL(rv);
-#else
-  ASSERT_LABEL(rv, dfsan_union(i_label, j_label));
-#endif
-
-  rv = strncasecmp(str1, str2, 3);
-  assert(rv == 0);
-  ASSERT_ZERO_LABEL(rv);
-}
-
-void test_strchr() {
-  char str1[] = "str1";
-  dfsan_set_label(i_label, &str1[3], 1);
-
-  char *crv = strchr(str1, 'r');
-  assert(crv == &str1[2]);
-  ASSERT_ZERO_LABEL(crv);
-
-  crv = strchr(str1, '1');
-  assert(crv == &str1[3]);
-#ifdef STRICT_DATA_DEPENDENCIES
-  ASSERT_ZERO_LABEL(crv);
-#else
-  ASSERT_LABEL(crv, i_label);
-#endif
-
-  crv = strchr(str1, 'x');
-  assert(!crv);
-#ifdef STRICT_DATA_DEPENDENCIES
-  ASSERT_ZERO_LABEL(crv);
-#else
-  ASSERT_LABEL(crv, i_label);
-#endif
-}
-
-void test_calloc() {
-  // With any luck this sequence of calls will cause calloc to return the same
-  // pointer both times.  This is probably the best we can do to test this
-  // function.
-  char *crv = calloc(4096, 1);
-  ASSERT_ZERO_LABEL(crv[0]);
-  dfsan_set_label(i_label, crv, 100);
-  free(crv);
-
-  crv = calloc(4096, 1);
-  ASSERT_ZERO_LABEL(crv[0]);
-  free(crv);
-}
-
-void test_read() {
-  char buf[16];
-  dfsan_set_label(i_label, buf, 1);
-  dfsan_set_label(j_label, buf + 15, 1);
-
-  ASSERT_LABEL(buf[0], i_label);
-  ASSERT_LABEL(buf[15], j_label);
-
-  int fd = open("/dev/zero", O_RDONLY);
-  int rv = read(fd, buf, sizeof(buf));
-  assert(rv == sizeof(buf));
-  ASSERT_ZERO_LABEL(rv);
-  ASSERT_ZERO_LABEL(buf[0]);
-  ASSERT_ZERO_LABEL(buf[15]);
-  close(fd);
-}
-
-void test_pread() {
-  char buf[16];
-  dfsan_set_label(i_label, buf, 1);
-  dfsan_set_label(j_label, buf + 15, 1);
-
-  ASSERT_LABEL(buf[0], i_label);
-  ASSERT_LABEL(buf[15], j_label);
-
-  int fd = open("/bin/sh", O_RDONLY);
-  int rv = pread(fd, buf, sizeof(buf), 0);
-  assert(rv == sizeof(buf));
-  ASSERT_ZERO_LABEL(rv);
-  ASSERT_ZERO_LABEL(buf[0]);
-  ASSERT_ZERO_LABEL(buf[15]);
-  close(fd);
-}
-
-void test_dlopen() {
-  void *map = dlopen(NULL, RTLD_NOW);
-  assert(map);
-  ASSERT_ZERO_LABEL(map);
-  dlclose(map);
-  map = dlopen("/nonexistent", RTLD_NOW);
-  assert(!map);
-  ASSERT_ZERO_LABEL(map);
-}
-
-void test_clock_gettime() {
-  struct timespec tp;
-  dfsan_set_label(j_label, ((char *)&tp) + 3, 1);
-  int t = clock_gettime(CLOCK_REALTIME, &tp);
-  assert(t == 0);
-  ASSERT_ZERO_LABEL(t);
-  ASSERT_ZERO_LABEL(((char *)&tp)[3]);
-}
-
-void test_ctime_r() {
-  char *buf = (char*) malloc(64);
-  time_t t = 0;
-
-  char *ret = ctime_r(&t, buf);
-  ASSERT_ZERO_LABEL(ret);
-  assert(buf == ret);
-  ASSERT_READ_ZERO_LABEL(buf, strlen(buf) + 1);
-
-  dfsan_set_label(i_label, &t, sizeof(t));
-  ret = ctime_r(&t, buf);
-  ASSERT_ZERO_LABEL(ret);
-  ASSERT_READ_LABEL(buf, strlen(buf) + 1, i_label);
-
-  t = 0;
-  dfsan_set_label(j_label, &buf, sizeof(&buf));
-  ret = ctime_r(&t, buf);
-  ASSERT_LABEL(ret, j_label);
-  ASSERT_READ_ZERO_LABEL(buf, strlen(buf) + 1);
-}
-
-static int write_callback_count = 0;
-static int last_fd;
-static const void *last_buf;
-static size_t last_count;
-
-void write_callback(int fd, const void *buf, size_t count) {
-  write_callback_count++;
-
-  last_fd = fd;
-  last_buf = buf;
-  last_count = count;
-}
-
-void test_dfsan_set_write_callback() {
-  char buf[] = "Sample chars";
-  int buf_len = strlen(buf);
-
-  int fd = open("/dev/null", O_WRONLY);
-
-  dfsan_set_write_callback(write_callback);
-
-  write_callback_count = 0;
-
-  // Callback should be invoked on every call to write().
-  int res = write(fd, buf, buf_len);
-  assert(write_callback_count == 1);
-  ASSERT_READ_ZERO_LABEL(&res, sizeof(res));
-  ASSERT_READ_ZERO_LABEL(&last_fd, sizeof(last_fd));
-  ASSERT_READ_ZERO_LABEL(last_buf, sizeof(last_buf));
-  ASSERT_READ_ZERO_LABEL(&last_count, sizeof(last_count));
-
-  // Add a label to write() arguments.  Check that the labels are readable from
-  // the values passed to the callback.
-  dfsan_set_label(i_label, &fd, sizeof(fd));
-  dfsan_set_label(j_label, &(buf[3]), 1);
-  dfsan_set_label(k_label, &buf_len, sizeof(buf_len));
-  
-  res = write(fd, buf, buf_len);
-  assert(write_callback_count == 2);
-  ASSERT_READ_ZERO_LABEL(&res, sizeof(res));
-  ASSERT_READ_LABEL(&last_fd, sizeof(last_fd), i_label);
-  ASSERT_READ_LABEL(&last_buf[3], sizeof(last_buf[3]), j_label);
-  ASSERT_READ_LABEL(last_buf, sizeof(last_buf), j_label);
-  ASSERT_READ_LABEL(&last_count, sizeof(last_count), k_label);
-
-  dfsan_set_write_callback(NULL);
-}
-
-void test_fgets() {
-  char *buf = (char*) malloc(128);
-  FILE *f = fopen("/etc/passwd", "r");
-  dfsan_set_label(j_label, buf, 1);
-  char *ret = fgets(buf, sizeof(buf), f);
-  assert(ret == buf);
-  ASSERT_ZERO_LABEL(ret);
-  ASSERT_READ_ZERO_LABEL(buf, 128);
-  dfsan_set_label(j_label, &buf, sizeof(&buf));
-  ret = fgets(buf, sizeof(buf), f);
-  ASSERT_LABEL(ret, j_label);
-  fclose(f);
-}
-
-void test_getcwd() {
-  char buf[1024];
-  char *ptr = buf;
-  dfsan_set_label(i_label, buf + 2, 2);
-  char* ret = getcwd(buf, sizeof(buf));
-  assert(ret == buf);
-  assert(ret[0] == '/');
-  ASSERT_READ_ZERO_LABEL(buf + 2, 2);
-  dfsan_set_label(i_label, &ptr, sizeof(ptr));
-  ret = getcwd(ptr, sizeof(buf));
-  ASSERT_LABEL(ret, i_label);
-}
-
-void test_get_current_dir_name() {
-  char* ret = get_current_dir_name();
-  assert(ret);
-  assert(ret[0] == '/');
-  ASSERT_READ_ZERO_LABEL(ret, strlen(ret) + 1);
-}
-
-void test_gethostname() {
-  char buf[1024];
-  dfsan_set_label(i_label, buf + 2, 2);
-  assert(gethostname(buf, sizeof(buf)) == 0);
-  ASSERT_READ_ZERO_LABEL(buf + 2, 2);
-}
-
-void test_getrlimit() {
-  struct rlimit rlim;
-  dfsan_set_label(i_label, &rlim, sizeof(rlim));
-  assert(getrlimit(RLIMIT_CPU, &rlim) == 0);
-  ASSERT_READ_ZERO_LABEL(&rlim, sizeof(rlim));
-}
-
-void test_getrusage() {
-  struct rusage usage;
-  dfsan_set_label(i_label, &usage, sizeof(usage));
-  assert(getrusage(RUSAGE_SELF, &usage) == 0);
-  ASSERT_READ_ZERO_LABEL(&usage, sizeof(usage));
-}
-
-void test_strcpy() {
-  char src[] = "hello world";
-  char dst[sizeof(src) + 2];
-  dfsan_set_label(0, src, sizeof(src));
-  dfsan_set_label(0, dst, sizeof(dst));
-  dfsan_set_label(i_label, src + 2, 1);
-  dfsan_set_label(j_label, src + 3, 1);
-  dfsan_set_label(j_label, dst + 4, 1);
-  dfsan_set_label(i_label, dst + 12, 1);
-  char *ret = strcpy(dst, src);
-  assert(ret == dst);
-  assert(strcmp(src, dst) == 0);
-  for (int i = 0; i < strlen(src) + 1; ++i) {
-    assert(dfsan_get_label(dst[i]) == dfsan_get_label(src[i]));
-  }
-  // Note: if strlen(src) + 1 were used instead to compute the first untouched
-  // byte of dest, the label would be I|J. This is because strlen() might
-  // return a non-zero label, and because by default pointer labels are not
-  // ignored on loads.
-  ASSERT_LABEL(dst[12], i_label);
-}
-
-void test_strtol() {
-  char buf[] = "1234578910";
-  char *endptr = NULL;
-  dfsan_set_label(i_label, buf + 1, 1);
-  dfsan_set_label(j_label, buf + 10, 1);
-  long int ret = strtol(buf, &endptr, 10);
-  assert(ret == 1234578910);
-  assert(endptr == buf + 10);
-  ASSERT_LABEL(ret, i_j_label);
-}
-
-void test_strtoll() {
-  char buf[] = "1234578910 ";
-  char *endptr = NULL;
-  dfsan_set_label(i_label, buf + 1, 1);
-  dfsan_set_label(j_label, buf + 2, 1);
-  long long int ret = strtoll(buf, &endptr, 10);
-  assert(ret == 1234578910);
-  assert(endptr == buf + 10);
-  ASSERT_LABEL(ret, i_j_label);
-}
-
-void test_strtoul() {
-  char buf[] = "0xffffffffffffaa";
-  char *endptr = NULL;
-  dfsan_set_label(i_label, buf + 1, 1);
-  dfsan_set_label(j_label, buf + 2, 1);
-  long unsigned int ret = strtol(buf, &endptr, 16);
-  assert(ret == 72057594037927850);
-  assert(endptr == buf + 16);
-  ASSERT_LABEL(ret, i_j_label);
-}
-
-void test_strtoull() {
-  char buf[] = "0xffffffffffffffaa";
-  char *endptr = NULL;
-  dfsan_set_label(i_label, buf + 1, 1);
-  dfsan_set_label(j_label, buf + 2, 1);
-  long long unsigned int ret = strtoull(buf, &endptr, 16);
-  assert(ret == 0xffffffffffffffaa);
-  assert(endptr == buf + 18);
-  ASSERT_LABEL(ret, i_j_label);
-}
-
-void test_strtod() {
-  char buf[] = "12345.76 foo";
-  char *endptr = NULL;
-  dfsan_set_label(i_label, buf + 1, 1);
-  dfsan_set_label(j_label, buf + 6, 1);
-  double ret = strtod(buf, &endptr);
-  assert(ret == 12345.76);
-  assert(endptr == buf + 8);
-  ASSERT_LABEL(ret, i_j_label);
-}
-
-void test_time() {
-  time_t t = 0;
-  dfsan_set_label(i_label, &t, 1);
-  time_t ret = time(&t);
-  assert(ret == t);
-  assert(ret > 0);
-  ASSERT_ZERO_LABEL(t);
-}
-
-void test_inet_pton() {
-  char addr4[] = "127.0.0.1";
-  dfsan_set_label(i_label, addr4 + 3, 1);
-  struct in_addr in4;
-  int ret4 = inet_pton(AF_INET, addr4, &in4);
-  assert(ret4 == 1);
-  ASSERT_READ_LABEL(&in4, sizeof(in4), i_label);
-  assert(in4.s_addr == 0x0100007f);
-
-  char addr6[] = "::1";
-  dfsan_set_label(j_label, addr6 + 3, 1);
-  struct in6_addr in6;
-  int ret6 = inet_pton(AF_INET6, addr6, &in6);
-  assert(ret6 == 1);
-  ASSERT_READ_LABEL(((char *) &in6) + sizeof(in6) - 1, 1, j_label);
-}
-
-void test_localtime_r() {
-  time_t t0 = 1384800998;
-  struct tm t1;
-  dfsan_set_label(i_label, &t0, sizeof(t0));
-  struct tm* ret = localtime_r(&t0, &t1);
-  assert(ret == &t1);
-  assert(t1.tm_min == 56);
-  ASSERT_LABEL(t1.tm_mon, i_label);
-}
-
-void test_getpwuid_r() {
-  struct passwd pwd;
-  char buf[1024];
-  struct passwd *result;
-
-  dfsan_set_label(i_label, &pwd, 4);
-  int ret = getpwuid_r(0, &pwd, buf, sizeof(buf), &result);
-  assert(ret == 0);
-  assert(strcmp(pwd.pw_name, "root") == 0);
-  assert(result == &pwd);
-  ASSERT_READ_ZERO_LABEL(&pwd, 4);
-}
-
-void test_poll() {
-  struct pollfd fd;
-  fd.fd = 0;
-  fd.events = POLLIN;
-  dfsan_set_label(i_label, &fd.revents, sizeof(fd.revents));
-  int ret = poll(&fd, 1, 1);
-  ASSERT_ZERO_LABEL(fd.revents);
-  assert(ret >= 0);
-}
-
-void test_select() {
-  struct timeval t;
-  fd_set fds;
-  t.tv_sec = 2;
-  FD_SET(0, &fds);
-  dfsan_set_label(i_label, &fds, sizeof(fds));
-  dfsan_set_label(j_label, &t, sizeof(t));
-  int ret = select(1, &fds, NULL, NULL, &t);
-  assert(ret >= 0);
-  ASSERT_ZERO_LABEL(t.tv_sec);
-  ASSERT_READ_ZERO_LABEL(&fds, sizeof(fds));
-}
-
-void test_sched_getaffinity() {
-  cpu_set_t mask;
-  dfsan_set_label(j_label, &mask, 1);
-  int ret = sched_getaffinity(0, sizeof(mask), &mask);
-  assert(ret == 0);
-  ASSERT_READ_ZERO_LABEL(&mask, sizeof(mask));
-}
-
-void test_sigemptyset() {
-  sigset_t set;
-  dfsan_set_label(j_label, &set, 1);
-  int ret = sigemptyset(&set);
-  assert(ret == 0);
-  ASSERT_READ_ZERO_LABEL(&set, sizeof(set));
-}
-
-void test_sigaction() {
-  struct sigaction oldact;
-  dfsan_set_label(j_label, &oldact, 1);
-  int ret = sigaction(SIGUSR1, NULL, &oldact);
-  assert(ret == 0);
-  ASSERT_READ_ZERO_LABEL(&oldact, sizeof(oldact));
-}
-
-void test_gettimeofday() {
-  struct timeval tv;
-  struct timezone tz;
-  dfsan_set_label(i_label, &tv, sizeof(tv));
-  dfsan_set_label(j_label, &tz, sizeof(tz));
-  int ret = gettimeofday(&tv, &tz);
-  assert(ret == 0);
-  ASSERT_READ_ZERO_LABEL(&tv, sizeof(tv));
-  ASSERT_READ_ZERO_LABEL(&tz, sizeof(tz));
-}
-
-void *pthread_create_test_cb(void *p) {
-  assert(p == (void *)1);
-  ASSERT_ZERO_LABEL(p);
-  return (void *)2;
-}
-
-void test_pthread_create() {
-  pthread_t pt;
-  pthread_create(&pt, 0, pthread_create_test_cb, (void *)1);
-  void *cbrv;
-  pthread_join(pt, &cbrv);
-  assert(cbrv == (void *)2);
-}
-
-int dl_iterate_phdr_test_cb(struct dl_phdr_info *info, size_t size,
-                            void *data) {
-  assert(data == (void *)3);
-  ASSERT_ZERO_LABEL(info);
-  ASSERT_ZERO_LABEL(size);
-  ASSERT_ZERO_LABEL(data);
-  return 0;
-}
-
-void test_dl_iterate_phdr() {
-  dl_iterate_phdr(dl_iterate_phdr_test_cb, (void *)3);
-}
-
-void test_strrchr() {
-  char str1[] = "str1str1";
-  dfsan_set_label(i_label, &str1[7], 1);
-
-  char *rv = strrchr(str1, 'r');
-  assert(rv == &str1[6]);
-#ifdef STRICT_DATA_DEPENDENCIES
-  ASSERT_ZERO_LABEL(rv);
-#else
-  ASSERT_LABEL(rv, i_label);
-#endif
-}
-
-void test_strstr() {
-  char str1[] = "str1str1";
-  dfsan_set_label(i_label, &str1[3], 1);
-  dfsan_set_label(j_label, &str1[5], 1);
-
-  char *rv = strstr(str1, "1s");
-  assert(rv == &str1[3]);
-#ifdef STRICT_DATA_DEPENDENCIES
-  ASSERT_ZERO_LABEL(rv);
-#else
-  ASSERT_LABEL(rv, i_label);
-#endif
-
-  rv = strstr(str1, "2s");
-  assert(rv == NULL);
-#ifdef STRICT_DATA_DEPENDENCIES
-  ASSERT_ZERO_LABEL(rv);
-#else
-  ASSERT_LABEL(rv, i_j_label);
-#endif
-}
-
-void test_memchr() {
-  char str1[] = "str1";
-  dfsan_set_label(i_label, &str1[3], 1);
-  dfsan_set_label(j_label, &str1[4], 1);
-
-  char *crv = memchr(str1, 'r', sizeof(str1));
-  assert(crv == &str1[2]);
-  ASSERT_ZERO_LABEL(crv);
-
-  crv = memchr(str1, '1', sizeof(str1));
-  assert(crv == &str1[3]);
-#ifdef STRICT_DATA_DEPENDENCIES
-  ASSERT_ZERO_LABEL(crv);
-#else
-  ASSERT_LABEL(crv, i_label);
-#endif
-
-  crv = memchr(str1, 'x', sizeof(str1));
-  assert(!crv);
-#ifdef STRICT_DATA_DEPENDENCIES
-  ASSERT_ZERO_LABEL(crv);
-#else
-  ASSERT_LABEL(crv, i_j_label);
-#endif
-}
-
-void alarm_handler(int unused) {
-  ;
-}
-
-void test_nanosleep() {
-  struct timespec req, rem;
-  req.tv_sec = 1;
-  req.tv_nsec = 0;
-  dfsan_set_label(i_label, &rem, sizeof(rem));
-
-  // non interrupted
-  int rv = nanosleep(&req, &rem);
-  assert(rv == 0);
-  ASSERT_ZERO_LABEL(rv);
-  ASSERT_READ_LABEL(&rem, 1, i_label);
-
-  // interrupted by an alarm
-  signal(SIGALRM, alarm_handler);
-  req.tv_sec = 3;
-  alarm(1);
-  rv = nanosleep(&req, &rem);
-  assert(rv == -1);
-  ASSERT_ZERO_LABEL(rv);
-  ASSERT_READ_ZERO_LABEL(&rem, sizeof(rem));
-}
-
-void test_socketpair() {
-  int fd[2];
-
-  dfsan_set_label(i_label, fd, sizeof(fd));
-  int rv = socketpair(PF_LOCAL, SOCK_STREAM, 0, fd);
-  assert(rv == 0);
-  ASSERT_ZERO_LABEL(rv);
-  ASSERT_READ_ZERO_LABEL(fd, sizeof(fd));
-}
-
-void test_write() {
-  int fd = open("/dev/null", O_WRONLY);
-
-  char buf[] = "a string";
-  int len = strlen(buf);
-
-  // The result of a write always unlabeled.
-  int res = write(fd, buf, len);
-  assert(res > 0);
-  ASSERT_ZERO_LABEL(res);
-
-  // Label all arguments to write().
-  dfsan_set_label(i_label, &(buf[3]), 1);
-  dfsan_set_label(j_label, &fd, sizeof(fd));
-  dfsan_set_label(i_label, &len, sizeof(len));
-
-  // The value returned by write() should have no label.
-  res = write(fd, buf, len);
-  ASSERT_ZERO_LABEL(res);
-
-  close(fd);
-}
-
-int main(void) {
-  i_label = dfsan_create_label("i", 0);
-  j_label = dfsan_create_label("j", 0);
-  k_label = dfsan_create_label("k", 0);
-  i_j_label = dfsan_union(i_label, j_label);
-
-  test_calloc();
-  test_clock_gettime();
-  test_ctime_r();
-  test_dfsan_set_write_callback();
-  test_dl_iterate_phdr();
-  test_dlopen();
-  test_fgets();
-  test_fstat();
-  test_get_current_dir_name();
-  test_getcwd();
-  test_gethostname();
-  test_getpwuid_r();
-  test_getrlimit();
-  test_getrusage();
-  test_gettimeofday();
-  test_inet_pton();
-  test_localtime_r();
-  test_memchr();
-  test_memcmp();
-  test_memcpy();
-  test_memset();
-  test_nanosleep();
-  test_poll();
-  test_pread();
-  test_pthread_create();
-  test_read();
-  test_sched_getaffinity();
-  test_select();
-  test_sigaction();
-  test_sigemptyset();
-  test_socketpair();
-  test_stat();
-  test_strcasecmp();
-  test_strchr();
-  test_strcmp();
-  test_strcpy();
-  test_strdup();
-  test_strlen();
-  test_strncasecmp();
-  test_strncmp();
-  test_strncpy();
-  test_strrchr();
-  test_strstr();
-  test_strtod();
-  test_strtol();
-  test_strtoll();
-  test_strtoul();
-  test_strtoull();
-  test_time();
-  test_write();
-}

Copied: compiler-rt/trunk/test/dfsan/custom.cc (from r219288, compiler-rt/trunk/test/dfsan/custom.c)
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/dfsan/custom.cc?p2=compiler-rt/trunk/test/dfsan/custom.cc&p1=compiler-rt/trunk/test/dfsan/custom.c&r1=219288&r2=219293&rev=219293&view=diff
==============================================================================
--- compiler-rt/trunk/test/dfsan/custom.c (original)
+++ compiler-rt/trunk/test/dfsan/custom.cc Wed Oct  8 05:01:42 2014
@@ -5,7 +5,6 @@
 
 // Tests custom implementations of various glibc functions.
 
-#define _GNU_SOURCE
 #include <sanitizer/dfsan_interface.h>
 
 #include <arpa/inet.h>
@@ -18,6 +17,7 @@
 #include <sched.h>
 #include <signal.h>
 #include <stdio.h>
+#include <stdint.h>
 #include <stdlib.h>
 #include <string.h>
 #include <sys/select.h>
@@ -256,12 +256,12 @@ void test_calloc() {
   // With any luck this sequence of calls will cause calloc to return the same
   // pointer both times.  This is probably the best we can do to test this
   // function.
-  char *crv = calloc(4096, 1);
+  char *crv = (char *) calloc(4096, 1);
   ASSERT_ZERO_LABEL(crv[0]);
   dfsan_set_label(i_label, crv, 100);
   free(crv);
 
-  crv = calloc(4096, 1);
+  crv = (char *) calloc(4096, 1);
   ASSERT_ZERO_LABEL(crv[0]);
   free(crv);
 }
@@ -342,14 +342,14 @@ void test_ctime_r() {
 
 static int write_callback_count = 0;
 static int last_fd;
-static const void *last_buf;
+static const unsigned char *last_buf;
 static size_t last_count;
 
 void write_callback(int fd, const void *buf, size_t count) {
   write_callback_count++;
 
   last_fd = fd;
-  last_buf = buf;
+  last_buf = (const unsigned char*) buf;
   last_count = count;
 }
 
@@ -376,7 +376,7 @@ void test_dfsan_set_write_callback() {
   dfsan_set_label(i_label, &fd, sizeof(fd));
   dfsan_set_label(j_label, &(buf[3]), 1);
   dfsan_set_label(k_label, &buf_len, sizeof(buf_len));
-  
+
   res = write(fd, buf, buf_len);
   assert(write_callback_count == 2);
   ASSERT_READ_ZERO_LABEL(&res, sizeof(res));
@@ -694,11 +694,11 @@ void test_memchr() {
   dfsan_set_label(i_label, &str1[3], 1);
   dfsan_set_label(j_label, &str1[4], 1);
 
-  char *crv = memchr(str1, 'r', sizeof(str1));
+  char *crv = (char *) memchr(str1, 'r', sizeof(str1));
   assert(crv == &str1[2]);
   ASSERT_ZERO_LABEL(crv);
 
-  crv = memchr(str1, '1', sizeof(str1));
+  crv = (char *) memchr(str1, '1', sizeof(str1));
   assert(crv == &str1[3]);
 #ifdef STRICT_DATA_DEPENDENCIES
   ASSERT_ZERO_LABEL(crv);
@@ -706,7 +706,7 @@ void test_memchr() {
   ASSERT_LABEL(crv, i_label);
 #endif
 
-  crv = memchr(str1, 'x', sizeof(str1));
+  crv = (char *) memchr(str1, 'x', sizeof(str1));
   assert(!crv);
 #ifdef STRICT_DATA_DEPENDENCIES
   ASSERT_ZERO_LABEL(crv);
@@ -774,6 +774,124 @@ void test_write() {
   close(fd);
 }
 
+template <class T>
+void test_sprintf_chunk(const char* expected, const char* format, T arg) {
+  char buf[512];
+  memset(buf, 'a', sizeof(buf));
+
+  char padded_expected[512];
+  strcpy(padded_expected, "foo ");
+  strcat(padded_expected, expected);
+  strcat(padded_expected, " bar");
+
+  char padded_format[512];
+  strcpy(padded_format, "foo ");
+  strcat(padded_format, format);
+  strcat(padded_format, " bar");
+
+  // Non labelled arg.
+  assert(sprintf(buf, padded_format,  arg) == strlen(padded_expected));
+  assert(strcmp(buf, padded_expected) == 0);
+  ASSERT_READ_LABEL(buf, strlen(padded_expected), 0);
+  memset(buf, 'a', sizeof(buf));
+
+  // Labelled arg.
+  dfsan_set_label(i_label, &arg, sizeof(arg));
+  assert(sprintf(buf, padded_format,  arg) == strlen(padded_expected));
+  assert(strcmp(buf, padded_expected) == 0);
+  ASSERT_READ_LABEL(buf, 4, 0);
+  ASSERT_READ_LABEL(buf + 4, strlen(padded_expected) - 8, i_label);
+  ASSERT_READ_LABEL(buf + (strlen(padded_expected) - 4), 4, 0);
+}
+
+void test_sprintf() {
+  char buf[2048];
+  memset(buf, 'a', sizeof(buf));
+
+  // Test formatting (no conversion specifier).
+  assert(sprintf(buf, "Hello world!") == 12);
+  assert(strcmp(buf, "Hello world!") == 0);
+  ASSERT_READ_LABEL(buf, sizeof(buf), 0);
+
+  // Test formatting & label propagation (multiple conversion specifiers): %s,
+  // %d, %n, %f, and %%.
+  const char* s = "world";
+  int m = 8;
+  int d = 27;
+  dfsan_set_label(k_label, (void *) (s + 1), 2);
+  dfsan_set_label(i_label, &m, sizeof(m));
+  dfsan_set_label(j_label, &d, sizeof(d));
+  int n;
+  int r = sprintf(buf, "hello %s, %-d/%d/%d %f %% %n%d", s, 2014, m, d,
+                  12345.6781234, &n, 1000);
+  assert(r == 42);
+  assert(strcmp(buf, "hello world, 2014/8/27 12345.678123 % 1000") == 0);
+  ASSERT_READ_LABEL(buf, 7, 0);
+  ASSERT_READ_LABEL(buf + 7, 2, k_label);
+  ASSERT_READ_LABEL(buf + 9, 9, 0);
+  ASSERT_READ_LABEL(buf + 18, 1, i_label);
+  ASSERT_READ_LABEL(buf + 19, 1, 0);
+  ASSERT_READ_LABEL(buf + 20, 2, j_label);
+  ASSERT_READ_LABEL(buf + 22, 15, 0);
+  ASSERT_LABEL(r, 0);
+  assert(n == 38);
+
+  // Test formatting & label propagation (single conversion specifier, with
+  // additional length and precision modifiers).
+  test_sprintf_chunk("-559038737", "%d", 0xdeadbeef);
+  test_sprintf_chunk("3735928559", "%u", 0xdeadbeef);
+  test_sprintf_chunk("12345", "%i", 12345);
+  test_sprintf_chunk("751", "%o", 0751);
+  test_sprintf_chunk("babe", "%x", 0xbabe);
+  test_sprintf_chunk("0000BABE", "%.8X", 0xbabe);
+  test_sprintf_chunk("-17", "%hhd", 0xdeadbeef);
+  test_sprintf_chunk("-16657", "%hd", 0xdeadbeef);
+  test_sprintf_chunk("deadbeefdeadbeef", "%lx", 0xdeadbeefdeadbeef);
+  test_sprintf_chunk("0xdeadbeefdeadbeef", "%p",
+                 (void *)  0xdeadbeefdeadbeef);
+  test_sprintf_chunk("18446744073709551615", "%ju", (intmax_t) -1);
+  test_sprintf_chunk("18446744073709551615", "%zu", (size_t) -1);
+  test_sprintf_chunk("18446744073709551615", "%tu", (size_t) -1);
+
+  test_sprintf_chunk("0x1.f9acffa7eb6bfp-4", "%a", 0.123456);
+  test_sprintf_chunk("0X1.F9ACFFA7EB6BFP-4", "%A", 0.123456);
+  test_sprintf_chunk("0.12346", "%.5f", 0.123456);
+  test_sprintf_chunk("0.123456", "%g", 0.123456);
+  test_sprintf_chunk("1.234560e-01", "%e", 0.123456);
+  test_sprintf_chunk("1.234560E-01", "%E", 0.123456);
+  test_sprintf_chunk("0.1234567891234560", "%.16Lf",
+                     (long double) 0.123456789123456);
+
+  test_sprintf_chunk("z", "%c", 'z');
+
+  // %n, %s, %d, %f, and %% already tested
+}
+
+void test_snprintf() {
+  char buf[2048];
+  memset(buf, 'a', sizeof(buf));
+  dfsan_set_label(0, buf, sizeof(buf));
+  const char* s = "world";
+  int y = 2014;
+  int m = 8;
+  int d = 27;
+  dfsan_set_label(k_label, (void *) (s + 1), 2);
+  dfsan_set_label(i_label, &y, sizeof(y));
+  dfsan_set_label(j_label, &m, sizeof(m));
+  int r = snprintf(buf, 19, "hello %s, %-d/%d/%d %f", s, y, m, d,
+                   12345.6781234);
+  // The return value is the number of bytes that would have been written to
+  // the final string if enough space had been available.
+  assert(r == 35);
+  assert(memcmp(buf, "hello world, 2014/", 19) == 0);
+  ASSERT_READ_LABEL(buf, 7, 0);
+  ASSERT_READ_LABEL(buf + 7, 2, k_label);
+  ASSERT_READ_LABEL(buf + 9, 4, 0);
+  ASSERT_READ_LABEL(buf + 13, 4, i_label);
+  ASSERT_READ_LABEL(buf + 17, 2, 0);
+  ASSERT_LABEL(r, 0);
+}
+
 int main(void) {
   i_label = dfsan_create_label("i", 0);
   j_label = dfsan_create_label("j", 0);
@@ -810,7 +928,9 @@ int main(void) {
   test_select();
   test_sigaction();
   test_sigemptyset();
+  test_snprintf();
   test_socketpair();
+  test_sprintf();
   test_stat();
   test_strcasecmp();
   test_strchr();

Modified: compiler-rt/trunk/test/sanitizer_common/lit.common.cfg
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/sanitizer_common/lit.common.cfg?rev=219293&r1=219292&r2=219293&view=diff
==============================================================================
--- compiler-rt/trunk/test/sanitizer_common/lit.common.cfg (original)
+++ compiler-rt/trunk/test/sanitizer_common/lit.common.cfg Wed Oct  8 05:01:42 2014
@@ -31,4 +31,3 @@ config.suffixes = ['.c', '.cc', '.cpp']
 
 if config.host_os not in ['Linux', 'Darwin']:
   config.unsupported = True
-





More information about the llvm-commits mailing list