[llvm] r219175 - [InstCombine] re-commit r218721 icmp-select-icmp optimization

Gerolf Hoflehner ghoflehner at apple.com
Tue Oct 7 23:57:19 PDT 2014


The is fixed in Committed revision 219282.

-Gerolf

> On Oct 7, 2014, at 6:17 PM, Hans Wennborg <hans at chromium.org> wrote:
> 
> On Mon, Oct 6, 2014 at 5:16 PM, Gerolf Hoflehner <ghoflehner at apple.com <mailto:ghoflehner at apple.com>> wrote:
>> Author: ghoflehner
>> Date: Mon Oct  6 19:16:12 2014
>> New Revision: 219175
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=219175&view=rev
>> Log:
>> [InstCombine] re-commit r218721 icmp-select-icmp optimization
>> 
>> Takes care of the assert that caused build fails.
>> Rather than asserting the code checks now that the definition
>> and use are in the same block, and does not attempt
>> to optimize when that is not the case.
> 
> I have reverted this in r219264, as it was causing miscompiles (PR21199).
> 
> - Hans

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141007/997634ce/attachment.html>


More information about the llvm-commits mailing list