[PATCH] [dwarfdump] Resolve also variable specifications/abstract_origins.

Alexey Samsonov vonosmas at gmail.com
Mon Oct 6 13:44:25 PDT 2014

Comment at: lib/DebugInfo/DWARFDebugInfoEntry.h:139
@@ +138,3 @@
+  getName(const DWARFUnit *U,
+          DILineInfoSpecifier::FunctionNameKind Kind,
+          bool SearchOnlySubroutine = false) const;
DILineInfoSpecifier::FunctionNameKind looks kind of weird here. Maybe, you should just add a custom enum that would set the kind of name you want to fetch from the DIE (in this way, you might never need to handle FunctionNameKind::None, for instance). Why do you need a SearchOnlySubroutine argument? I don't think a suprogram DIE can refer to a variable DIE via DW_AT_specification attribute.


More information about the llvm-commits mailing list