[PATCH] [Polly][Refactor] Change the comment style to silence -Wcomment

Tobias Grosser tobias at grosser.es
Mon Oct 6 00:09:11 PDT 2014


On 05/10/2014 13:50, Johannes Doerfert wrote:
> Hi grosser,
>
>    -Wcomment complained about a "multi-line comment" caused by the
>     ascii art used in ScopHelper to describe the CFG.

Using C style comments is inconsistent to the common LLVM style and
is normally avoided e.g. due to nesting problems they can cause.

http://llvm.org/docs/CodingStandards.html#source-code-formatting

> -    // EnteringBB
> -    //     |
> -    //    / \
> -    //    |  \-> some_other_BB_not_in_R

The last time this issue appeared Sebastian fixed it by replacing the 
offending '\' character by '|'.

-------------------------------------------------------------------------
commit 68fe241052d775cc0b996aa19499640d9b1a531c
Author: Sebastian Pop <spop at codeaurora.org>
Date:   Thu Mar 13 16:28:02 2014 +0000

     avoid warning

     warning: multi-line comment [-Wcomment]

     git-svn-id: https://llvm.org/svn/llvm-project/polly/trunk@203811 
91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/lib/CodeGen/LoopGenerators.cpp b/lib/CodeGen/LoopGenerators.cpp
index 5815879..b82819e 100644
--- a/lib/CodeGen/LoopGenerators.cpp
+++ b/lib/CodeGen/LoopGenerators.cpp
@@ -29,8 +29,8 @@ using namespace polly;
  //                 |
  //                 v
  //              GuardBB
-//              /      \
-//     __  PreHeaderBB  \
+//              /      |
+//     __  PreHeaderBB  |
  //    /  \    /         |
  // latch  HeaderBB      |
  //    \  /    \         /
-------------------------------------------------------------------------

That seems to be a good solution.

Tobias



More information about the llvm-commits mailing list