[compiler-rt] r219040 - Fix the armv7 thumb builtins on darwin

[İsmail Dönmez]

Hi,

On Sat, Oct 4, 2014 at 11:21 PM, Bob Wilson <bob.wilson at apple.com> wrote:

>
> On Oct 4, 2014, at 12:14 PM, İsmail Dönmez <ismail at donmez.ws> wrote:
>
> Hi,
>
> On Sat, Oct 4, 2014 at 9:25 PM, Bob Wilson <bob.wilson at apple.com> wrote:
>>
>> r219064 should fix it.
>>
>>
> Doesn't seem to work (tried r219064)
>
> ../projects/compiler-rt/lib/builtins/arm/sync_fetch_and_max_8.S:20:92:
> error: unexpected token in argument list
> .p2align 2 ; .thumb ; .syntax unified ; ; .globl __sync_fetch_and_max_8 ;
> THUMB_FUNC .type __sync_fetch_and_max_8,%function ; __sync_fetch_and_max_8:
> push {r4, r5, r6, lr} ; dmb ; mov r12, r0 ; .L_tryatomic_max_8: ldrexd r0,
> r1, [r12] ; cmp r0, r2 ; sbcs r1, r3 ; mov r4, r2 ; mov r5, r3 ; itt gt ;
> movgt r4, r0 ; movgt r5, r1 ; strexd r6, r4, r5, [r12] ; cmp r6, #0 ; bne
> .L_tryatomic_max_8 ; dmb ; pop {r4, r5, r6, pc}
>
>                  ^
> ../projects/compiler-rt/lib/builtins/arm/sync_fetch_and_add_8.S:22:92:
> error: unexpected token in argument list
> .p2align 2 ; .thumb ; .syntax unified ; ; .globl __sync_fetch_and_add_8 ;
> THUMB_FUNC .type __sync_fetch_and_add_8,%function ; __sync_fetch_and_add_8:
> push {r4, r5, r6, lr} ; dmb ; mov r12, r0 ; .L_tryatomic_add_8: ldrexd r0,
> r1, [r12] ; adds r4, r0, r2 ; adc r5, r1, r3 ; strexd r6, r4, r5, [r12] ;
> cmp r6, #0 ; bne .L_tryatomic_add_8 ; dmb ; pop {r4, r5, r6, pc}
>
>                  ^
>
>
> Sorry. How about with r219066?
>

That works, thanks!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141005/ecf34447/attachment.html>