[PATCH] [dwarfdump] Print the name for referenced specification of abstract_origin DIEs.

David Blaikie dblaikie at gmail.com
Fri Oct 3 15:46:06 PDT 2014


Looks good - just some optional bits/questions/ideas.

================
Comment at: test/DebugInfo/Inputs/gmlt.ll:46
@@ -45,3 +45,3 @@
 
-; CHECK: [[F3_ABS_DEF:.*]]:  DW_TAG_subprogram
+; CHECK: DW_TAG_subprogram
 ; CHECK-NEXT:     DW_AT_name {{.*}} "f3"
----------------
Not sure - might even be worth dropping these abstract subprograms entirely when they're not checking anything interesting (just the name is being checked by the abstract_definition check you modified below). *shrug* dunno.

================
Comment at: test/DebugInfo/X86/inline-member-function.ll:24
@@ +23,3 @@
+; CHECK: DW_AT_specification {{.*}} "_ZN3foo4funcEi"
+; CHECK-NOT: NULL
+; CHECK-NOT: TAG
----------------
Could write this as {{NULL|TAG}} (& update the other one nearby to do that for consistency). If you like.

================
Comment at: test/DebugInfo/X86/inline-seldag-test.ll:14
@@ -13,3 +13,1 @@
 
-; CHECK: [[F:.*]]: DW_TAG_subprogram
-; CHECK-NOT: DW_TAG
----------------
I see you dropped the abs def checking in this case - why this case & not others?

================
Comment at: test/DebugInfo/inline-scopes.ll:29
@@ +28,3 @@
+; CHECK-NOT: {{DW_TAG|NULL}}
+; CHECK:   DW_TAG_lexical_block
+; CHECK-NOT: {{DW_TAG|NULL}}
----------------
{{NULL|DW_TAG}} ?

http://reviews.llvm.org/D5466






More information about the llvm-commits mailing list