[PATCH] [AArch64] Generate vector signed/unsigned mul and mla/mls long

Chad Rosier mcrosier at codeaurora.org
Fri Oct 3 07:26:24 PDT 2014


================
Comment at: test/CodeGen/AArch64/aarch64-smull.ll:227
@@ +226,3 @@
+define <8 x i16> @smull_extvec_v8i8_v8i16(<8 x i8> %arg) nounwind {
+; CHECK-LABEL: smull_extvec_v8i8_v8i16
+; CHECK: smull {{v[0-9]+}}.8h, {{v[0-9]+}}.8b, {{v[0-9]+}}.8b
----------------
Please be consistent with your CHECK directives.  Specifically, either do or don't include a space between the ; and the CHECK for each test.  Personally, I prefer a space and I believe this is the general style within the community.

http://reviews.llvm.org/D5589






More information about the llvm-commits mailing list