[PATCH] Add basic conditional branches in mips fast-isel

Daniel Sanders daniel.sanders at imgtec.com
Fri Oct 3 03:52:49 PDT 2014

LGTM with a couple extra comments

Comment at: lib/Target/Mips/MipsFastISel.cpp:345
@@ +344,3 @@
+        .addMBB(TBB);
+    fastEmitBranch(FBB, DbgLoc);
+    FuncInfo.MBB->addSuccessor(TBB);
This confused me for a moment. Could you make it a bit clearer that we're working on the else case at this point?

Comment at: test/CodeGen/Mips/Fast-ISel/br1.ll:23
@@ +22,3 @@
+  ret void
+; CHECK:  xor  $[[REG1:[0-9]+]], ${{[0-9]+}}, $zero
+; CHECK:  sltiu  $[[REG2:[0-9]+]], $[[REG1]], 1
It's not necessary for this patch but this instruction is redundant and should be trivial to eliminate. Could you add a FIXME comment to this test?


More information about the llvm-commits mailing list