[PATCH] Move sanitizer bots's configs from an external repo to zorg

Renato Golin renato.golin at linaro.org
Fri Oct 3 01:17:09 PDT 2014

>>! In D5531#11, @rnk wrote:
> I should also mention that using these funky shell scripts in this way makes it possible for any committer to make changes the buildbot script and have it go live on the next build without waiting for a master restart.

I wanted this before, but I was sceptical to its value. I don't have a strong opinion about separating the scripts to make bot changes easier, but I'd prefer less bash and more python.

If the need to have bash is so it can work better at the shell level, than make the bash part the minimum necessary. Right now, you're duplicating a lot of the functionality on both shell and batch versions, things that the Builder library already does it better. 

For example, we're in the process of unifying the repository checkout (svn, git, etc) for the ClangCMakeBuilder and this could be replicated across all other bots (since they all do the same thing), but with your current implementation you won't benefit from it and will increase the maintenance cost.

Also, please use:

  #!/usr/bin/env bash

instead of:


to make sure it'll work *everywhere*.


More information about the llvm-commits mailing list