[llvm] r218784 - LTO: Ignore disabled diagnostic remarks

Duncan P. N. Exon Smith dexonsmith at apple.com
Thu Oct 2 14:24:29 PDT 2014


>> Modified: llvm/trunk/lib/LTO/LTOCodeGenerator.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/LTO/LTOCodeGenerator.cpp?rev=218784&r1=218783&r2=218784&view=diff
>> ==============================================================================
>> --- llvm/trunk/lib/LTO/LTOCodeGenerator.cpp (original)
>> +++ llvm/trunk/lib/LTO/LTOCodeGenerator.cpp Wed Oct  1 13:36:03 2014
>> @@ -558,5 +558,5 @@ LTOCodeGenerator::setDiagnosticHandler(l
>>     return Context.setDiagnosticHandler(nullptr, nullptr);
>>   // Register the LTOCodeGenerator stub in the LLVMContext to forward the
>>   // diagnostic to the external DiagHandler.
>> -  Context.setDiagnosticHandler(LTOCodeGenerator::DiagnosticHandler, this);
>> +  Context.setDiagnosticHandler(LTOCodeGenerator::DiagnosticHandler, this, true);
> 
> This reads a little bit nicer if you explain what the boolean argument
> is here, like /*RespectFilters=*/true

r218907



More information about the llvm-commits mailing list