[PATCH] Support invoking the patchpoint intrinsic
chandlerc at google.com
Thu Oct 2 00:17:43 PDT 2014
Hey Andy, Kevin,
Just as a heads up, this patch hit a common usage problem we have with
Phabricator: the initial patch was created without llvm-commits, and then
when it as added no email was actually sent to the list. So all anyone has
seen is Andy's response.
Given the widespread interest in things like patchpoint intrinsics, I think
it would be worth updating this thread with a reasonably good introduction
to what the patch is trying to do so that others can see it.
(also, as I have mentioned in other threads about Phabricator, I strongly
suggest that everyone using it to initiate a code review *check the mailing
list* to ensure the first email arrived)
On Thu, Oct 2, 2014 at 12:08 AM, Andrew Trick <atrick at apple.com> wrote:
> I think patching an exception throwing call is valid. You can certainly
> have an inline cache to an exception throwing method.
> I also think it's valid to use the platform's exception handling support,
> although probably not performant if your app throws exceptions. As Filip
> mentioned, the best approach is to profile the throws, deoptimize when they
> aren't expected and emit branches when they are.
> Anyway, great work. Please add tests and cleanup the code as you mentioned.
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-commits