[PATCH] [ASan] Make stack-buffer-overflow reports more robust

Alexey Samsonov vonosmas at gmail.com
Wed Oct 1 14:39:29 PDT 2014


================
Comment at: lib/asan/asan_report.cc:458
@@ -456,1 +457,3 @@
   // Report all objects in this frame.
+  const uptr kBufSize = 4095;
+  char buf[kBufSize];
----------------
samsonov wrote:
> kcc wrote:
> > Isn't this buffer too large? (we may get stack overflow while reporting)
> Yeah, we may get rid of this buffer completely. I'll address this in a separate change.
Done in r218827.

http://reviews.llvm.org/D5554






More information about the llvm-commits mailing list