[llvm] r218786 - LTO: Add missing target triple from r218784

Duncan P. N. Exon Smith dexonsmith at apple.com
Wed Oct 1 13:08:53 PDT 2014


> On Oct 1, 2014, at 12:45 PM, Diego Novillo <dnovillo at google.com> wrote:
> 
> On Wed, Oct 1, 2014 at 3:16 PM, Duncan P. N. Exon Smith
> <dexonsmith at apple.com> wrote:
>> Diego,
>> 
>> I aded the triple because -pass-remarks don't seem to work on x86_64-unknown-linux-gnu.
>> 
>> I.e., if you change the triple in this testcase to:
>> 
>>    target triple = "x86_64-unknown-linux-gnu"
>> 
>> The test fails like this:
>> 
>> Command Output (stderr):
>> --
>> /Volumes/Data/llvm/bugfixes/test/LTO/diagnostic-handler-remarks.ll:26:12: error: expected string not found in input
>> ; REMARKS: remark:
>>           ^
>> <stdin>:1:1: note: scanning from here
>> 
>> ^
>> 
>> --
>> 
>> Is this expected, or should I file a PR?
> 
> Could you file a PR? Without having looked at it, I'm puzzled as to
> why you'd need this. I should be able to take a look soonish.
> 
> 
> Thanks. Diego.

PR21120.



More information about the llvm-commits mailing list