[llvm] r198019 - [Mips] Does not take in account 'use-soft-float' attribute's value when

[Daniel Sanders]

> -----Original Message-----
> From: Eric Christopher [mailto:echristo at gmail.com]
> Sent: 30 September 2014 17:50
> To: Daniel Sanders
> Cc: Reed Kotler; Simon Atanasyan; llvm-commits at cs.uiuc.edu
> Subject: Re: [llvm] r198019 - [Mips] Does not take in account 'use-soft-float'
> attribute's value when
> 
> On Tue, Sep 30, 2014 at 5:51 AM, Daniel Sanders
> <Daniel.Sanders at imgtec.com> wrote:
> >> > There is one test that is failing locally for us that started to fail around
> >> > the time when you were making changes
> >> > and it may be unrelated to that, but it's a test for this dual 32/16 mode
> >> > switching ability. I have been busy and
> >> > did not look at this failure yet because I did not know about it when it
> >> > first happened because we had some other
> >> > issues unrelated to that in our local build bots at exactly that moment
> that
> >> > masked the problem.
> >> >
> >>
> >> Likely the problem I'm fixing here. If you change the order of
> >> functions in the test suite for the test I have modified you'll see a
> >> failure.
> >>
> >
> > Am I right in thinking you're referring to
> MultiSource/UnitTests/Mips/Mips16/fp16_32_1/fp16_32_1 failure from
> https://dmz-
> portal.mips.com/bb/builders/LLVM%20with%2016bit%20and%20delay%20sl
> ot%20optimizer%20and%20hard%20float/builds/780? I've just taken a look at
> that one and it's a qemu bug. http://patchwork.ozlabs.org/patch/366146/
> fixes the problem for me.
> >
> 
> Nope. That bot, afaict, doesn't send out email or irc notices so I
> don't even know it exists :)
>
> The testcase I added with the fix shows the problem - it would only
> have come up if you were mixing IR with soft and hard float turned on
> per-function.
> 
> -eric

I meant the regression that Reed mentioned. :-)

Regarding the buildbot, I linked you to it when you asked me about our test systems but that was a long time ago now (June?). More importantly, we're upgrading our test facilities and sending notifications is one of the things we intend to sort out.