[PATCH] [x86] Simplify vector selection

Chandler Carruth chandlerc at google.com
Wed Oct 1 02:40:22 PDT 2014

On Wed, Oct 1, 2014 at 2:37 AM, Robert Khasanov <rob.khasanov at gmail.com>

> Hi Chandler,
> In addition to Adam's comment (Thanks Adam for answers), you can see
> thread
> http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20140929/237328.html
> If you feel strongly, I can split this patch into two: VSELECT
> simplification (with test) and changes in intrinsics lowering.

His comment makes sense.

Please add a test case specifically for the VSELECT simplification you are
expecting that just uses VSELECT. We really don't want to build up reliance
on DAG combines of generic DAG nodes that are only tested indirectly.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141001/5a4e4484/attachment.html>

More information about the llvm-commits mailing list