[PATCH] [MemoryDependenceAnalysis] Fix compile time slowdown

hfinkel at anl.gov hfinkel at anl.gov
Tue Sep 30 15:43:51 PDT 2014


LGTM too.

================
Comment at: lib/Analysis/MemoryDependenceAnalysis.cpp:1139
@@ -1135,1 +1138,3 @@
 
+    // If we do process more than one hundred blocks it becomes very expensive
+    // and likely it isn't worth worrying about
----------------
I'd replace "one hundred" in the comment, and just say "If we do process a large number of blocks..." (the comment could become confusing if the limit is ever adjusted).

http://reviews.llvm.org/D5532






More information about the llvm-commits mailing list