[PATCH] demangle undefined symbol names in error message

Tim Northover t.p.northover at gmail.com
Tue Sep 30 14:28:39 PDT 2014


Hi Nick,

The code looks reasonable to me. One comment on the tests though...

Cheers.

Tim.

================
Comment at: test/mach-o/demangle.yaml:33-34
@@ +32,4 @@
+        symbol:          1
+global-symbols:
+  - name:            __Z1xv
+    type:            N_SECT
----------------
Any chance you could add 1 or 2 weird symbols here too (non-C++ and perhaps one without any underscore)? Since this is used for diagnostics when things have gone wrong, it's fairly important it won't crash and burn then.

http://reviews.llvm.org/D5549






More information about the llvm-commits mailing list