[ASAN/AArch64] Fix kernel_old_Xid_t type

Christophe Lyon christophe.lyon at linaro.org
Mon Sep 29 15:14:56 PDT 2014


On 29 September 2014 23:55, Kostya Serebryany <kcc at google.com> wrote:
> [I know this may sound ridiculous for a trivial one-line patch, but...]
Indeed, especially since I wasn't aware of this patch until Andreas
sent a link about it.

> Please create a patch that applies to the *llvm* tree, not to the gcc tree
> (for historical reasons sanitizer code have slightly different directory
> structure in llvm and gcc).
> Please then have it tested there and send it to this list.
I have no test case.

> We highly prefer the use of http://llvm.org/docs/Phabricator.html, but for
> trivial patches like this we can relax the requirement.
>
> --kcc
>
> On Mon, Sep 29, 2014 at 2:44 PM, Christophe Lyon
> <christophe.lyon at linaro.org> wrote:
>>
>> On 29 September 2014 23:23, Kostya Serebryany <kcc at google.com> wrote:
>> > Please actually post the patch here.
>> >
>>
>> OK, so let me try again...
>>
>> > On Mon, Sep 29, 2014 at 1:37 PM, Renato Golin <renato.golin at linaro.org>
>> > wrote:
>> >>
>> >> Copying Kostya, FYI.
>> >>
>> >> On 29 September 2014 20:43, Christophe Lyon
>> >> <christophe.lyon at linaro.org>
>> >> wrote:
>> >> > Hello,
>> >> >
>> >> > After I have recently enabled asan on AArch64 in GCC, Andreas Schwab
>> >> > noticed that a patch is needed in libsanitizer for this platform.
>> >> >
>> >> > See:
>> >> > https://gcc.gnu.org/ml/gcc-patches/2014-09/msg02437.html
>> >> >
>> Here is the message in question, from Andreas Schwab:
>>
>>
>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=34c65c4
>>
>> * sanitizer_common/sanitizer_platform_limits_posix.h
>> (__sanitizer___kernel_old_uid_t, __sanitizer___kernel_old_gid_t)
>> [__aarch64__]: Define to unsigned short.
>>
>> The patch is attached to avoid indentation problems caused by the mailers.
>>
>> Christophe.
>>
>>
>> >> > Can you apply it, and then merge it into GCC?
>> >> >
>> >> > Thanks.
>> >> >
>> >> > Christophe.
>> >> > _______________________________________________
>> >> > llvm-commits mailing list
>> >> > llvm-commits at cs.uiuc.edu
>> >> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>> >
>> >
>
>



More information about the llvm-commits mailing list