[PATCH] [SimplifyCFG] Double check for constant expression domination

Nick Lewycky nicholas at mxc.ca
Mon Sep 29 13:00:06 PDT 2014


hfinkel at anl.gov wrote:
> This does not seem like the right fix. What is isSafeToSpeculativelyExecute checking that C->canTrap is not checking? I'd think that fixing C->canTrap is the right way to address this problem.

I'd also like to make a plea for a testcase here. If we had a testcase, 
we could see for ourselves what isSafeToSpeculativelyExecute is checking 
that c->canTrap isn't.

>
> http://reviews.llvm.org/D5459
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>




More information about the llvm-commits mailing list