[PATCH] Factor the Unit section parsing into the DWARFUnitSection class.

Alexey Samsonov vonosmas at gmail.com
Mon Sep 29 11:58:11 PDT 2014


================
Comment at: lib/DebugInfo/DWARFUnit.h:59
@@ -57,3 +58,3 @@
   DWARFUnitSection(DWARFUnitSection &&DUS) :
     SmallVector<std::unique_ptr<UnitType>, 1>(std::move(DUS)) {}
 
----------------
initialize Parsed in this constructor as well.

================
Comment at: lib/DebugInfo/DWARFUnit.h:65
@@ -63,1 +64,3 @@
 
+  void parse(DWARFContext &Context, const DWARFDebugAbbrev *DA,
+             StringRef Section, StringRef RS, StringRef SS, StringRef SOS,
----------------
Can't you fetch all the sections' contents (debug_abbrev, debug_ranges, debug_addr etc.) by using a "Context" argument?

http://reviews.llvm.org/D5522






More information about the llvm-commits mailing list