[PATCH] Provide the name for labels inside MS asm blocks to clang as the branch targets for each asm block

Ehsan Akhgari ehsan.akhgari at gmail.com
Mon Sep 29 10:57:16 PDT 2014


>>! In D5515#4, @rnk wrote:
> I don't think we need this, LookupInlineAsmLabel should be able to track all the LabelDecl's that got created during inline asm parsing.

Well, LookupInlineAsmLabel would not be able to associate a label name with an MSAsmStmt, which we later on need to use in order to check whether the branch target is defined inside another MSAsmStmt on the clang side.  Also, note that this patch provides two bits of information, the "labels defined" and the "branch targets".  The branch targets cannot be deciphered from LookupInlineAsmLabel, given the fact that you can do things such as `mov eax, LabelName` that are not branches.

http://reviews.llvm.org/D5515






More information about the llvm-commits mailing list