[PATCH] Add support for annotated minimum dependence distance

hfinkel at anl.gov hfinkel at anl.gov
Sun Sep 28 01:05:53 PDT 2014


Generally speaking, I think this is fine. You definitely need to run this through clang-format (which you can do directly on the patch file, IIRC), or manually fix the formatting to comply with the LLVM coding conventions.

However, if the main use case for this is dealing with OpenMP's safelen (and possibly other similar user-provided safety assertions), then I would like to get a resolution on the lexical dependency question (i.e. whether we really also need some ordering construct here).

Also, for future reference, please upload full-context diffs (see http://llvm.org/docs/Phabricator.html for instructions).

http://reviews.llvm.org/D5123






More information about the llvm-commits mailing list