[PATCH] Teach zorg to support cmake and modules for Clang builders

Richard Smith richard at metafoo.co.uk
Fri Sep 26 17:03:54 PDT 2014


Thanks! I switched this over to enabling modules via the new -DLLVM_ENABLE_MODULES=1 flag and committed as r218557.

================
Comment at: zorg/buildbot/builders/ClangBuilder.py:332
@@ +331,3 @@
+    #
+    # It does not make sense to skip this for a bootstrap builder,
+    # and we don't support doing so for cmake builds.
----------------
dblaikie wrote:
> Maybe rephrase this (it leaves fairly ambiguous as to why we want to clean for the configure build here - the answer being "there's no known reason") maybe:
> 
> # FIXME: verify that there's no need to skip cleaning for the configure stage 2 build (it doesn't make much sense) and remove this condition
> 
> ?
Done.

http://reviews.llvm.org/D4936






More information about the llvm-commits mailing list