[PATCH] [lld] [ELF] Support for general dynamic TLS relocations on X86_64

Michael Spencer bigcheesegs at gmail.com
Fri Sep 26 12:47:17 PDT 2014


lgtm with the change.

================
Comment at: lib/ReaderWriter/ELF/Atoms.h:652-657
@@ -651,1 +651,8 @@
 
+class SimpleELFDynamicAtom : public SharedLibraryAtom {
+public:
+  SimpleELFDynamicAtom() : SharedLibraryAtom() {}
+
+  virtual Scope scope() const = 0;
+};
+
----------------
Not sure this is needed. TLSGETADDRAtom can just directly derive from SharedLibraryAtom.

http://reviews.llvm.org/D5505






More information about the llvm-commits mailing list