[PATCH] Add support for intercepting functions from msvcr110.dll

Timur Iskhodzhanov timurrrr at google.com
Thu Sep 25 13:28:28 PDT 2014


Formatting nit, otherwise LGTM.

================
Comment at: lib/interception/interception_win.cc:186
@@ -186,1 +185,3 @@
+  const char *InterestingDLLs[] = { "kernel32.dll", "msvcr110.dll",
+                                    "msvcr120.dll", NULL };
   static void *result[ARRAY_SIZE(InterestingDLLs)] = { 0 };
----------------
I'd much rather prefer something like
  const char *InterestingDLLs[] = { "kernel32.dll",
                                    "msvcr110.dll", // VS2012
                                    "msvcr120.dll", // VS2013
                                    NULL };
or
  const char *InterestingDLLs[] = {
    "kernel32.dll",
    "msvcr110.dll", // VS2012
    "msvcr120.dll", // VS2013
    NULL };
[please pick the version that clang-format likes more]
especially given the naming confusion (VS11=VS2012, VS12=VS2013).

What do you think?

http://reviews.llvm.org/D5494






More information about the llvm-commits mailing list