[llvm] r218393 - Revert "Refactor the RelocVisitor::visit method"

[Chandler Carruth]

On Wed, Sep 24, 2014 at 1:04 PM, Renato Golin <renato.golin at linaro.org>
wrote:

> Hi Kaelyn,
>
> Please don't revert patches just because it breaks one buildbot,
> especially if the fix is obvious and only in the test. This makes it
> hard to re-apply them later, and creates a lot of work for re-testing
> on slow hardware.
>

I specifically disagree. The policy for LLVM is to revert-to-green.

If a patch breaks a build bot, it is totally within scope to revert. If it
isn't blocking you making progress, then not a big deal to leave it in and
try to let the author fix it up.

But if the broken build bot represents your inability to build / test / etc
in any way, reverting to green is totally the right response.


>
> I saw the email, I was fixing it, but when you reverted, I had to
> start all over again. Next time, check the email, IRC or just mail the
> person responsible, and let them fix it.
>

She did email about this.

I'm not sure why you had to start all over again? My version control makes
it super easy to stash a fix, sync, un-revert, and re-apply my fix?

This is a reasonably common occurrence in LLVM for me and hasn't caused any
problems.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140924/1da4841c/attachment.html>