[llvm] r218397 - Revert "Report endianness in output of {dwarf, obj}dump"
James Molloy
james at jamesmolloy.co.uk
Wed Sep 24 14:28:37 PDT 2014
Hi Kaelyn,
As Renato emailed that he was working on this 5 minutes after you reported
the problem, do you not think this revert was slightly premature? Or is
there context (irc?) I'm missing?
Cheers,
James
On 24 Sep 2014 19:14, "Kaelyn Takata" <rikka at google.com> wrote:
> Author: rikka
> Date: Wed Sep 24 13:00:17 2014
> New Revision: 218397
>
> URL: http://llvm.org/viewvc/llvm-project?rev=218397&view=rev
> Log:
> Revert "Report endianness in output of {dwarf, obj}dump"
>
> This reverts commit r218391 as it depends on r218388 and r218389
>
> Removed:
> llvm/trunk/test/tools/llvm-dwarfdump/AArch64/little-endian-dump.ll
> llvm/trunk/test/tools/llvm-dwarfdump/ARM/little-endian-dump.ll
> Modified:
> llvm/trunk/include/llvm/Object/ELFObjectFile.h
> llvm/trunk/test/tools/llvm-dwarfdump/AArch64/big-endian-dump.ll
> llvm/trunk/test/tools/llvm-dwarfdump/ARM/big-endian-dump.ll
>
> Modified: llvm/trunk/include/llvm/Object/ELFObjectFile.h
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Object/ELFObjectFile.h?rev=218397&r1=218396&r2=218397&view=diff
>
> ==============================================================================
> --- llvm/trunk/include/llvm/Object/ELFObjectFile.h (original)
> +++ llvm/trunk/include/llvm/Object/ELFObjectFile.h Wed Sep 24 13:00:17 2014
> @@ -855,7 +855,6 @@ uint8_t ELFObjectFile<ELFT>::getBytesInA
>
> template <class ELFT>
> StringRef ELFObjectFile<ELFT>::getFileFormatName() const {
> - bool IsLittleEndian = ELFT::TargetEndianness == support::little;
> switch (EF.getHeader()->e_ident[ELF::EI_CLASS]) {
> case ELF::ELFCLASS32:
> switch (EF.getHeader()->e_machine) {
> @@ -864,7 +863,7 @@ StringRef ELFObjectFile<ELFT>::getFileFo
> case ELF::EM_X86_64:
> return "ELF32-x86-64";
> case ELF::EM_ARM:
> - return (IsLittleEndian ? "ELF32-arm-little" : "ELF32-arm-big");
> + return "ELF32-arm";
> case ELF::EM_HEXAGON:
> return "ELF32-hexagon";
> case ELF::EM_MIPS:
> @@ -884,7 +883,7 @@ StringRef ELFObjectFile<ELFT>::getFileFo
> case ELF::EM_X86_64:
> return "ELF64-x86-64";
> case ELF::EM_AARCH64:
> - return (IsLittleEndian ? "ELF64-aarch64-little" :
> "ELF64-aarch64-big");
> + return "ELF64-aarch64";
> case ELF::EM_PPC64:
> return "ELF64-ppc64";
> case ELF::EM_S390:
>
> Modified: llvm/trunk/test/tools/llvm-dwarfdump/AArch64/big-endian-dump.ll
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-dwarfdump/AArch64/big-endian-dump.ll?rev=218397&r1=218396&r2=218397&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/tools/llvm-dwarfdump/AArch64/big-endian-dump.ll
> (original)
> +++ llvm/trunk/test/tools/llvm-dwarfdump/AArch64/big-endian-dump.ll Wed
> Sep 24 13:00:17 2014
> @@ -1,7 +1,5 @@
> ; RUN: llc -O0 -filetype=obj -o %t1 < %s
> -; RUN: llvm-dwarfdump %t1 | FileCheck %s
> -
> -; CHECK: file format ELF64-aarch64-big
> +; RUN: llvm-dwarfdump %t1
>
> target datalayout = "E-m:e-i64:64-i128:128-n32:64-S128"
> target triple = "aarch64_be-none--eabi"
>
> Removed: llvm/trunk/test/tools/llvm-dwarfdump/AArch64/little-endian-dump.ll
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-dwarfdump/AArch64/little-endian-dump.ll?rev=218396&view=auto
>
> ==============================================================================
> --- llvm/trunk/test/tools/llvm-dwarfdump/AArch64/little-endian-dump.ll
> (original)
> +++ llvm/trunk/test/tools/llvm-dwarfdump/AArch64/little-endian-dump.ll
> (removed)
> @@ -1,18 +0,0 @@
> -; RUN: llc -O0 -filetype=obj -o %t1 < %s
> -; RUN: llvm-dwarfdump %t1 | FileCheck %s
> -
> -; CHECK: file format ELF64-aarch64-little
> -
> -target datalayout = "e-m:e-i64:64-i128:128-n32:64-S128"
> -target triple = "aarch64-none--eabi"
> -
> -!llvm.dbg.cu = !{!0}
> -!llvm.module.flags = !{!3, !4}
> -!llvm.ident = !{!5}
> -
> -!0 = metadata !{i32 786449, metadata !1, i32 12, metadata !"clang version
> 3.6.0 ", i1 false, metadata !"", i32 0, metadata !2, metadata !2, metadata
> !2, metadata !2, metadata !2, metadata !"", i32 1} ; [ DW_TAG_compile_unit
> ] [/a/empty.c] [DW_LANG_C99]
> -!1 = metadata !{metadata !"empty.c", metadata !"/a"}
> -!2 = metadata !{}
> -!3 = metadata !{i32 2, metadata !"Dwarf Version", i32 4}
> -!4 = metadata !{i32 2, metadata !"Debug Info Version", i32 1}
> -!5 = metadata !{metadata !"clang version 3.6.0 "}
>
> Modified: llvm/trunk/test/tools/llvm-dwarfdump/ARM/big-endian-dump.ll
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-dwarfdump/ARM/big-endian-dump.ll?rev=218397&r1=218396&r2=218397&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/tools/llvm-dwarfdump/ARM/big-endian-dump.ll (original)
> +++ llvm/trunk/test/tools/llvm-dwarfdump/ARM/big-endian-dump.ll Wed Sep 24
> 13:00:17 2014
> @@ -1,7 +1,5 @@
> ; RUN: llc -O0 -filetype=obj -o %t1 < %s
> -; RUN: llvm-dwarfdump %t1 | FileCheck %s
> -
> -; CHECK: file format ELF32-arm-big
> +; RUN: llvm-dwarfdump %t1
>
> target datalayout = "E-m:e-p:32:32-i64:64-v128:64:128-n32-S64"
> target triple = "armebv8-none--eabi"
>
> Removed: llvm/trunk/test/tools/llvm-dwarfdump/ARM/little-endian-dump.ll
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-dwarfdump/ARM/little-endian-dump.ll?rev=218396&view=auto
>
> ==============================================================================
> --- llvm/trunk/test/tools/llvm-dwarfdump/ARM/little-endian-dump.ll
> (original)
> +++ llvm/trunk/test/tools/llvm-dwarfdump/ARM/little-endian-dump.ll
> (removed)
> @@ -1,20 +0,0 @@
> -; RUN: llc -O0 -filetype=obj -o %t1 < %s
> -; RUN: llvm-dwarfdump %t1 | FileCheck %s
> -
> -; CHECK: file format ELF32-arm-little
> -
> -target datalayout = "e-m:e-p:32:32-i64:64-v128:64:128-n32-S64"
> -target triple = "armv8-none--eabi"
> -
> -!llvm.dbg.cu = !{!0}
> -!llvm.module.flags = !{!3, !4, !5, !6}
> -!llvm.ident = !{!7}
> -
> -!0 = metadata !{i32 786449, metadata !1, i32 12, metadata !"clang version
> 3.6.0 ", i1 false, metadata !"", i32 0, metadata !2, metadata !2, metadata
> !2, metadata !2, metadata !2, metadata !"", i32 1} ; [ DW_TAG_compile_unit
> ] [/a/empty.c] [DW_LANG_C99]
> -!1 = metadata !{metadata !"empty.c", metadata !"/a"}
> -!2 = metadata !{}
> -!3 = metadata !{i32 2, metadata !"Dwarf Version", i32 4}
> -!4 = metadata !{i32 2, metadata !"Debug Info Version", i32 1}
> -!5 = metadata !{i32 1, metadata !"wchar_size", i32 4}
> -!6 = metadata !{i32 1, metadata !"min_enum_size", i32 4}
> -!7 = metadata !{metadata !"clang version 3.6.0 "}
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140924/b5ecf66c/attachment.html>
More information about the llvm-commits
mailing list