[PATCH] Extend C disassembler API to allow specifying target features

Renato Golin renato.golin at linaro.org
Wed Sep 24 02:00:55 PDT 2014


Hi Bradley,

The patch looks good, though I have some comments inline.

cheers,
--renato

================
Comment at: test/Bindings/llvm-c/disassemble.test:14
@@ +13,3 @@
+;CHECK: b0                           ???
+;CHECK: f3                           ???
+
----------------
these checks look weird

================
Comment at: tools/llvm-c-test/disassemble.c:83
@@ -76,3 +82,3 @@
   }
-  do_disassemble(triple, disbuf, disbuflen);
+  do_disassemble(triple, features, disbuf, disbuflen);
 }
----------------
will there be any string validation further on? If yes, why do you do the NULL validation above? If not, shouldn't we add it?

http://reviews.llvm.org/D5468






More information about the llvm-commits mailing list