[PATCH] Do not destroy external linkage when deleting function body

Petar Jovanovic petarj at mips.com
Tue Sep 23 06:01:21 PDT 2014


================
Comment at: unittests/Bitcode/BitReaderTest.cpp:61
@@ -60,1 +60,3 @@
 
+TEST(BitReaderTest, DematerializeFunctionAndPreserveLinkageType) {
+  SmallString<1024> Mem;
----------------
mseaborn wrote:
> Nit: how about "DematerializeFunctionPreservesLinkageType" to capture the intent a little better?
Done.

================
Comment at: unittests/Bitcode/BitReaderTest.cpp:77
@@ +76,3 @@
+
+  // Check if the linkage type is preserved after dematerialization.
+  M->getFunction("func")->Dematerialize();
----------------
mseaborn wrote:
> Nit: change to "Check that..." (otherwise the comment doesn't make it clear whether the test wants the linkage preserved or not)
Done.

http://reviews.llvm.org/D5415






More information about the llvm-commits mailing list