[PATCH] ms-inline-asm: Fix parsing label names inside bracket expressions

Reid Kleckner rnk at google.com
Mon Sep 22 13:48:30 PDT 2014


lgtm

================
Comment at: lib/Target/X86/AsmParser/X86AsmParser.cpp:1344
@@ -1349,4 +1343,3 @@
   if (!Result) {
-    Identifier = SemaCallback->LookupInlineAsmLabel(Identifier, getSourceManager(), Loc, false);
-    assert(Identifier.size() && "We should have an internal name here.");
-    Info.InternalName = Identifier;
+    StringRef InternalName = SemaCallback->LookupInlineAsmLabel(Identifier, getSourceManager(), Loc, false);
+    assert(InternalName.size() && "We should have an internal name here.");
----------------
80cols

http://reviews.llvm.org/D5445






More information about the llvm-commits mailing list