[PATCH] [lld] [ELF] Fix linking when a regular object defines a symbol that is used in a DSO

Rui Ueyama ruiu at google.com
Mon Sep 22 11:23:43 PDT 2014


I just rolled back r218259 because the previous commit lacked .o and .so
files. It broke the buildbots. I'm sorry for the trouble.

Basically we avoid checking in binary files. Instead, we check in YAML
files created by obj2yaml command, and in each test we convert them back to
binary using yaml2obj. Can you update your patch that way?

On Mon, Sep 22, 2014 at 11:02 AM, Rui Ueyama <ruiu at google.com> wrote:

> Committed as r218259.
>
> On Mon, Sep 22, 2014 at 3:22 AM, Rafael Auler <rafaelauler at gmail.com>
> wrote:
>
>> Hi Shankar,
>>
>> I don't have commit access, could you please commit it?
>>
>> Thanks,
>> Rafael Auler
>>
>> On Sat, Sep 20, 2014 at 6:58 PM, Shankar Kalpathi Easwaran <
>> shankarke at gmail.com> wrote:
>>
>>> LGTM.
>>>
>>> http://reviews.llvm.org/D5424
>>>
>>>
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140922/b65de52e/attachment.html>


More information about the llvm-commits mailing list