[PATCH] Do not destroy external linkage when deleting function body

Rafael EspĂ­ndola rafael.espindola at gmail.com
Fri Sep 19 12:59:51 PDT 2014


On 19 September 2014 14:43, Mark Seaborn <mseaborn at chromium.org> wrote:
> LGTM.  Is there a way to test this, though?  Should there be a unit test to cover BitcodeReader::Dematerialize()?

On trunk this is only used by LinkModules.cpp, so I don't think it is
observable by any in tree tool.

LGTM with at test added to unittests/Bitcode/BitReaderTest.cpp.

Cheers,
Rafael



More information about the llvm-commits mailing list