[PATCH] [Fix] Allow pointer types as access elements and compare them correct

Johannes Doerfert doerfert at cs.uni-saarland.de
Fri Sep 19 02:00:33 PDT 2014


On 09/19, Tobias Grosser wrote:
> On 19/09/2014 10:54, Johannes Doerfert wrote:
> >On 09/19, Tobias Grosser wrote:
> >>Very nice fix and test case.
> >>
> >>There is a minor nit in the test case and you may want to mention that you choose i8 as the max type,
> >Updated.
> >
> >>================
> >>Comment at: test/Isl/CodeGen/aliasing_different_pointer_types.ll:1
> >>@@ +1,2 @@
> >>+; RUN: opt %loadPolly -polly-code-generator=isl -polly-codegen-isl -S < %s | FileCheck %s
> >>+;
> >>----------------
> >>-polly-code-generator=isl is not needed.
> >Not true, it is. Otherwise the alias RTC's will be disabled.
> 
> Ah, that is surprising.
It was the only way I saw to ensure alias RTC's are only enabled with
the isl backend. --polly-codegen-isl Is not a flag we can just "ask
for".
> 
> Anyhow, just leave it in. It will disappear when we remove CLooG.
That is true and till then it is not that bad.

> Cheers,
> Tobias
> 

-- 

Johannes Doerfert
Researcher / PhD Student

Compiler Design Lab (Prof. Hack)
Saarland University, Computer Science
Building E1.3, Room 4.26

Tel. +49 (0)681 302-57521 : doerfert at cs.uni-saarland.de
Fax. +49 (0)681 302-3065  : http://www.cdl.uni-saarland.de/people/doerfert
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 213 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140919/aafbbc2c/attachment.sig>


More information about the llvm-commits mailing list