[PATCH] [lld] Fixes wrong Twine uses in FileNode::errStr() and in LayoutPass.cpp

[Rafael Auler]

The tricky part is that this code causes no problem in unoptimized builds
and I think that is the reason why the buildbots missed this. If you make
an optimized build, at least with gcc (didn't test with clang), a bunch of
tests fail. I tracked this down with valgrind, not sure about MSan.

On Thu, Sep 18, 2014 at 8:39 PM, David Blaikie <dblaikie at gmail.com> wrote:

>
>
> On Thu, Sep 18, 2014 at 4:30 PM, kledzik at apple.com <kledzik at apple.com>
> wrote:
>
>> Is there some C++ language feature we can use to mark the Twine class in
>> a way that causes a warning/error on these incorrect usages?
>>
>
> I don't believe so - I think MSan is about the best tool we have for this
> (at least I think it should catch this sort of thing, but I might be wrong)
>
>
>>
>> http://reviews.llvm.org/D5405
>>
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140918/004f9647/attachment.html>