[PATCH] CFL AA Tests + Minor Fix

hfinkel at anl.gov hfinkel at anl.gov
Thu Sep 18 14:55:45 PDT 2014


================
Comment at: lib/Analysis/CFLAliasAnalysis.cpp:989
@@ -988,4 +988,3 @@
   auto AttrsB = Sets.getLink(SetB.Index).Attrs;
-  auto CombinedAttrs = AttrsA | AttrsB;
-  if (CombinedAttrs.any())
-    return AliasAnalysis::PartialAlias;
+  if (AttrsA.any() && AttrsB.any())
+    return AliasAnalysis::MayAlias;
----------------
Can you please add some comments here explaining what is going on? It seems like this is a significant change: Previously, we would return NoAlias only if none of the bits in either AttrsA or AttrsB were set. Now we'll return NoAlias if either of AttrsA or AttrsB have no bits set. So this seems to be doing much more than changing a PartialAlias to a MayAlias in some circumstances.

http://reviews.llvm.org/D5243






More information about the llvm-commits mailing list