[PATCH] New options for asan-symbolizer script: set cross-compile prefix, set path to sysroot, print help message

[Sergey Matveev]

================
Comment at: lib/asan/scripts/asan_symbolize.py:27
@@ -23,1 +26,3 @@
+fix_filename_patterns = None
+logfile = None
 
----------------
Why are we adding more global state? Why not make those into arguments of SymbolizationLoop's constructor?

If we *must* have them as globals, why not give them sane initial values? After this change, if I want to import SymbolizationLoop from this module (as we do in more than one place in Chromium), I have to do this:

import asan_symbolize
asan_symbolize.logfile = sys.stdin
symbolization_loop = asan_symbolize.SymbolizationLoop(...)

http://reviews.llvm.org/D4703