[PATCH] Add support for small-model PIC for PowerPC.

Justin Hibbits jrh29 at alumni.cwru.edu
Thu Sep 18 11:30:55 PDT 2014


================
Comment at: lib/Target/PowerPC/PPCAsmPrinter.cpp:415
@@ +414,3 @@
+      const MCExpr *PB =
+        MCSymbolRefExpr::Create(OutContext.GetOrCreateSymbol(Twine(".LTOC.")),
+                                                             OutContext);
----------------
hfinkel wrote:
> jhibbits wrote:
> > hfinkel wrote:
> > > Why?
> > This was part of the cleanup of the original check-in (because both implementations are rather intertwined in code touched, I lumped them together).  I can remove this change.
> Specifically, I mean that you renamed ".L.TOC." to ".LTOC.", and I am curious why.
Aesthetics only.  After submitting the PIC and TLS patches, I started cleaning up, and thought the .L.TOC. looked messy.  No other reason at all.

http://reviews.llvm.org/D5399






More information about the llvm-commits mailing list