[PATCH] lld: handling of -flavor / -core command line switches

Rui Ueyama ruiu at google.com
Wed Sep 17 13:08:10 PDT 2014


Nick's concern makes sense. We should allow -flavor only at the first
argument (i.e. argv[1]) because -flavor can be a valid command line
argument of the other linker.

You should process raw argv and argc first for -flavor, and then pass the
rest to parseArgs.

On Wed, Sep 17, 2014 at 12:44 PM, kledzik at apple.com <kledzik at apple.com>
wrote:

> The original design was that -flavor had to be the first arg (so
> incrementing argv worked).  But now the use of ParseArgs() means that
> -flavor is being searched for everywhere in the arg list. That is a
> mismatch.
>
> http://reviews.llvm.org/D5384
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140917/0e0fcac1/attachment.html>


More information about the llvm-commits mailing list